From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: David Turner <dturner@twopensource.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git mailing list <git@vger.kernel.org>
Subject: Re: mktree: multiple same-named objects
Date: Wed, 27 Aug 2014 08:17:15 -0700 [thread overview]
Message-ID: <xmqqk35uezd0.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140827051341.GB32141@peff.net> (Jeff King's message of "Wed, 27 Aug 2014 01:13:41 -0400")
Jeff King <peff@peff.net> writes:
> On Wed, Aug 27, 2014 at 12:41:57AM -0400, David Turner wrote:
>
>> git mktree seems to allow the creation of a tree object with multiple
>> objects of the same name but different SHAs.
>
> Yeah, I don't think we do many quality checks there. Ditto for "git
> hash-object".
I am somewhat against outright removing the capability to write out
invalid objects deliberately from these low level tools, because we
would need a way to easily reproduce bugs in end-user facing tools
by other people who claim to produce Git objects, but I would agree
that by default that should be forbidden.
In other words, two things must happen; improve checks when these
low level debugging aid tools are creating objects, and allow
bypassing these additional checks with "--experiment" option or
something.
next prev parent reply other threads:[~2014-08-27 15:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 4:41 mktree: multiple same-named objects David Turner
2014-08-27 5:01 ` Duy Nguyen
2014-08-27 21:48 ` David Turner
2014-08-27 5:13 ` Jeff King
2014-08-27 15:17 ` Junio C Hamano [this message]
2014-08-27 16:24 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk35uezd0.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.