From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH 1/4] completion: add missing terminator in case statement Date: Mon, 21 Jul 2014 13:09:13 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: git@vger.kernel.org To: John Keeping X-From: git-owner@vger.kernel.org Mon Jul 21 22:09:27 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X9Jtm-0006bD-Cb for gcvg-git-2@plane.gmane.org; Mon, 21 Jul 2014 22:09:26 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753428AbaGUUJW (ORCPT ); Mon, 21 Jul 2014 16:09:22 -0400 Received: from smtp.pobox.com ([208.72.237.35]:60727 "EHLO smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753284AbaGUUJV (ORCPT ); Mon, 21 Jul 2014 16:09:21 -0400 Received: from smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp0.pobox.com (Postfix) with ESMTP id 428622B637; Mon, 21 Jul 2014 16:09:21 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=a5BXbOyIRabawwl8qjJgLbrw9+A=; b=mKXlui 7fV0vuVNxMm4qbR8N9NaPfkR9fAdJYNTw7CNTGVgBXuiAHIzd4CLt+cVYbWPEt1G Eyrn468KqQ7BL/298z4qsR9r8SvlHj0w4TQrgIgdlCUTOifVcGNEn2qBD4gLHEmo RKXIK2Cd6dz+frtIu5ceKxnFZGzeXJidS1sOg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=czq+IcVT9Eb+iyWAgMPEeHYocEzqfX2E zQIHwJI2kNz6Ja2JknN37dSrPGtLASS2dqqR6pONyPVsTiLHHPDOTKGz0kMtrnQx pbWYLzpOavCbcOgMT2aeJVOfbPcbOhDRC4vx6vluBEP/+zeZKZX6gsZOhIVSnvHQ arEciVTz46E= Received: from pb-smtp0.int.icgroup.com (unknown [127.0.0.1]) by pb-smtp0.pobox.com (Postfix) with ESMTP id 33A462B636; Mon, 21 Jul 2014 16:09:21 -0400 (EDT) Received: from pobox.com (unknown [72.14.226.9]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by pb-smtp0.pobox.com (Postfix) with ESMTPSA id 4C06D2B62B; Mon, 21 Jul 2014 16:09:15 -0400 (EDT) In-Reply-To: (Junio C. Hamano's message of "Mon, 21 Jul 2014 10:26:47 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) X-Pobox-Relay-ID: E394A448-1112-11E4-B9FE-9903E9FBB39C-77302942!pb-smtp0.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Junio C Hamano writes: > John Keeping writes: > >> Signed-off-by: John Keeping >> --- > > As these ;; are separators not terminators, this is not strictly > necessary. Squashing it into a change that adds more case arms to > this case statement is of course not just good but necessary, > though. s/necessary/may be &/; if you add new arms before this one, you won't need it. But if you add one after this, you would ;-). >> contrib/completion/git-completion.bash | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash >> index 7a6e1d7..d0b2895 100644 >> --- a/contrib/completion/git-completion.bash >> +++ b/contrib/completion/git-completion.bash >> @@ -1627,6 +1627,7 @@ _git_push () >> --repo) >> __gitcomp_nl "$(__git_remotes)" >> return >> + ;; >> esac >> case "$cur" in >> --repo=*)