All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jens Lehmann <Jens.Lehmann@web.de>
Cc: Chris Packham <judge.packham@gmail.com>,
	patthoyts@users.sourceforge.net, GIT <git@vger.kernel.org>
Subject: Re: [GIT GUI PATCH] git-gui: use vcompare when comparing the git version
Date: Wed, 14 May 2014 14:49:34 -0700	[thread overview]
Message-ID: <xmqqk39ohvyp.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqqlhu4jhcb.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Wed, 14 May 2014 12:22:28 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> Jens Lehmann <Jens.Lehmann@web.de> writes:
>
>> Junio, I believe this issue needs to be fixed before 2.0 final. Otherwise
>> git gui will not work inside submodules anymore due to the major version
>> number change from 1 to 2. I'd like to hear Pat's opinion on this; even
>> though I think my patch is less risky (as it doesn't change behavior for
>> pre-2 versions), he might like Chris' proposal better.
>
> Thanks; I share the same feeling.

So after checking git://repo.or.cz/git-gui.git/ and seeing that I am
not missing any commit from there, I tentatively created a fork of
it, applied your patch and merged it somewhere on 'pu' that is close
to 'next'.  We may want to fast-track it to 2.0 without waiting for
an Ack from Pat but let's give him one more day to respond.

  reply	other threads:[~2014-05-14 21:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-29  2:56 git gui error with relocated repository Chris Packham
2014-04-29  4:23 ` Chris Packham
2014-04-29 10:58   ` [GIT GUI PATCH] git-gui: unconditionally use rev-parse --show-toplevel Chris Packham
2014-05-06 12:10   ` git gui error with relocated repository Pat Thoyts
2014-05-07  7:28     ` Chris Packham
2014-05-07  7:49       ` Chris Packham
2014-05-13 21:24         ` [GIT GUI PATCH] git-gui: use vcompare when comparing the git version Jens Lehmann
2014-05-14  7:46           ` Chris Packham
2014-05-14  7:49           ` Jens Lehmann
2014-05-14 19:22             ` Junio C Hamano
2014-05-14 21:49               ` Junio C Hamano [this message]
2014-05-17 12:23                 ` Pat Thoyts
2014-05-17 19:49                   ` [GIT GUI PATCH v2] git-gui: tolerate major version changes " Jens Lehmann
2014-05-18  0:31                     ` Chris Packham
2014-05-18  3:01                     ` Eric Sunshine
2014-05-19 17:16                     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqk39ohvyp.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=Jens.Lehmann@web.de \
    --cc=git@vger.kernel.org \
    --cc=judge.packham@gmail.com \
    --cc=patthoyts@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.