From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: git@vger.kernel.org, Philip Oakley <philipoakley@iee.org>,
Thomas Rast <trast@inf.ethz.ch>, Johannes Sixt <j6t@kdbg.org>
Subject: Re: [PATCH v2 1/5] replace: forbid replacing an object with one of a different type
Date: Tue, 27 Aug 2013 13:30:03 -0700 [thread overview]
Message-ID: <xmqqk3j6c1x0.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20130827194828.11172.73829.chriscool@tuxfamily.org> (Christian Couder's message of "Tue, 27 Aug 2013 21:48:23 +0200")
Christian Couder <chriscool@tuxfamily.org> writes:
> Users replacing an object with one of a different type were not
> prevented to do so, even if it was obvious, and stated in the doc,
> that bad things would result from doing that.
>
> To avoid mistakes, it is better to just forbid that though.
>
> There is no case where one object can be replaced with one of a
> different type while keeping the history valid, because:
>
> * Annotated tags contain the type of the tagged object.
If you replace the tagged object and the tag at the same time,
wouldn't that make the resulting history valid again?
Granted, there may not be a strong reason to reuse the object name
of the tagged object in such a case, but this "there may not be" is
merely "I do not think of offhand", so I am not sure what workflow
of other people we are breaking with this change. A light-weight
tag may already point at the tagged object (in other words, the
object name of the tagged object is known to the outside world) and
that could be a reason why you would need to reuse the object name
of that object while changing its type.
I dunno.
next prev parent reply other threads:[~2013-08-27 20:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 19:48 [PATCH v2 0/5] Check replacement object type and minor updates Christian Couder
2013-08-27 19:48 ` [PATCH v2 1/5] replace: forbid replacing an object with one of a different type Christian Couder
2013-08-27 20:30 ` Junio C Hamano [this message]
2013-08-28 7:31 ` Thomas Rast
2013-08-28 19:32 ` Junio C Hamano
2013-08-29 6:29 ` Christian Couder
2013-08-29 16:04 ` Junio C Hamano
2013-08-30 5:41 ` Christian Couder
2013-08-30 16:52 ` Junio C Hamano
2013-08-27 19:48 ` [PATCH v2 2/5] Documentation/replace: state that objects must be of the same type Christian Couder
2013-08-27 19:48 ` [PATCH v2 3/5] t6050-replace: test that objects are " Christian Couder
2013-08-27 19:48 ` [PATCH v2 4/5] t6050-replace: add test to clean up all the replace refs Christian Couder
2013-08-27 19:48 ` [PATCH v2 5/5] Documentation/replace: add Creating Replacement Objects section Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk3j6c1x0.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=philipoakley@iee.org \
--cc=trast@inf.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.