From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Phil Hord <phil.hord@gmail.com>, Phil Hord <hordp@cisco.com>,
"git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [RFC/PATCH] Fix path prefixing in grep_object
Date: Sat, 24 Aug 2013 22:25:56 -0700 [thread overview]
Message-ID: <xmqqk3jal4t7.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20130825042314.GE2882@elie.Belkin> (Jonathan Nieder's message of "Sat, 24 Aug 2013 21:23:14 -0700")
Jonathan Nieder <jrnieder@gmail.com> writes:
> I think Phil meant that when "git grep" is asked to search within
> "HEAD:some/path", filenames tacked on at the end should be appended
> with a '/' separator instead of the usual ':' (e.g.,
> "HEAD:some/path/inner/path.c", not "HEAD:some/path:inner/path.c").
Ah, OK.
I am not sure if we have a proper hint in the revision parser
machinery, but it may not be too hard to teach rev-cmdline interface
to keep that kind of information (i.e. "This tree object name is a
result of parsing '<tree-ish>:path' syntax").
next prev parent reply other threads:[~2013-08-25 5:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-25 1:35 [RFC/PATCH] Fix path prefixing in grep_object Phil Hord
2013-08-25 2:07 ` Phil Hord
2013-08-25 3:35 ` Junio C Hamano
2013-08-25 4:23 ` Jonathan Nieder
2013-08-25 5:25 ` Junio C Hamano [this message]
2013-08-26 7:14 ` Junio C Hamano
2013-08-26 11:44 ` Phil Hord
2013-08-26 16:23 ` Junio C Hamano
2013-08-26 16:49 ` Phil Hord
2013-08-26 17:07 ` Phil Hord
2013-08-26 17:26 ` Junio C Hamano
2013-08-26 17:45 ` Phil Hord
2013-08-27 4:07 ` Junio C Hamano
2013-08-27 11:54 ` Phil Hord
2013-08-26 17:03 ` Junio C Hamano
2013-08-26 17:19 ` Phil Hord
2013-08-25 4:41 ` Jeff King
2013-08-25 5:41 ` Jonathan Nieder
2013-08-25 5:54 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk3jal4t7.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hordp@cisco.com \
--cc=jrnieder@gmail.com \
--cc=phil.hord@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.