All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Éric NICOLAS" <ccjmne@gmail.com>
Cc: git@vger.kernel.org,  jacob.keller@gmail.com
Subject: Re: [PATCH v2] submodule: resolve insteadOf aliases when matching remote
Date: Fri, 24 Jul 2026 13:36:51 -0700	[thread overview]
Message-ID: <xmqqldb05dlo.fsf@gitster.g> (raw)
In-Reply-To: <20260723002132.3989727-1-ccjmne@gmail.com> ("Éric NICOLAS"'s message of "Thu, 23 Jul 2026 02:21:32 +0200")

Éric NICOLAS <ccjmne@gmail.com> writes:

> - Reword the commit message more purposefully
> - Adjust the implementation as suggested, avoiding a superfluous
>   variable
> - Tidy up the integration test

Queued.

Is everybody happy with this version?

Thanks.

> diff --git a/t/t7406-submodule-update.sh b/t/t7406-submodule-update.sh
> index 9554720152..10adeabf0f 100755
> --- a/t/t7406-submodule-update.sh
> +++ b/t/t7406-submodule-update.sh
> @@ -256,6 +256,25 @@ test_expect_success 'submodule update --remote should fetch upstream changes' '
>  	)
>  '
>  
> +test_expect_success 'submodule update --remote resolves URL rewrites' '
> +	test_config_global "url.$(pwd)/.insteadOf" local: &&
> +	mkdir alias-super alias-submodule &&
> +	(
> +		cd alias-submodule &&
> +		git init &&
> +		git commit --allow-empty --message "Initial commit"
> +	) &&
> +	(
> +		cd alias-super &&
> +		git init &&
> +		git submodule add local:alias-submodule submodule &&
> +		git submodule update --force &&
> +		git -C submodule remote rename origin upstream &&
> +		git -C submodule remote add fork user@host &&
> +		git submodule update --remote
> +	)
> +'



      reply	other threads:[~2026-07-24 20:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-21 21:30 [PATCH] submodule: resolve insteadof-aliases when matching remote Éric NICOLAS
2026-07-22 19:49 ` Junio C Hamano
2026-07-23  0:21 ` [PATCH v2] submodule: resolve insteadOf aliases " Éric NICOLAS
2026-07-24 20:36   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqldb05dlo.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=ccjmne@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jacob.keller@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.