From: Junio C Hamano <gitster@pobox.com>
To: Adrian Friedli <adrian.friedli@mt.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH resend] builtin/clone: fix segfault when using --revision on some servers
Date: Fri, 24 Jul 2026 09:04:34 -0700 [thread overview]
Message-ID: <xmqqldb08jcd.fsf@gitster.g> (raw)
In-Reply-To: <20260724123735.666021-1-adrian.friedli@mt.com> (Adrian Friedli's message of "Fri, 24 Jul 2026 14:37:35 +0200")
Adrian Friedli <adrian.friedli@mt.com> writes:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> So this patch fixes the issue in the right place. It would still be
>> nice to have a new test to prevent future regressions, though.
>
> Thanks for your review.
>
> While implementing the test I discovered it is protocol version 0 which
> triggers that behavior. I updated the log message and implemented a test.
Oh, the proposed log message reads wonderfully. Thanks for digging
down to the root cause of the issue.
next prev parent reply other threads:[~2026-07-24 16:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 14:43 [PATCH resend] builtin/clone: fix segfault when using --revision on some servers Adrian Friedli
2026-07-23 15:43 ` Junio C Hamano
2026-07-23 16:10 ` Junio C Hamano
2026-07-24 12:37 ` Adrian Friedli
2026-07-24 16:04 ` Junio C Hamano [this message]
2026-07-24 12:41 ` [PATCH v2] builtin/clone: fix segfault when using --revision with protocol v0 Adrian Friedli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqldb08jcd.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=adrian.friedli@mt.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.