From: Junio C Hamano <gitster@pobox.com>
To: Paulius Zaleckas <paulius.zaleckas@gmail.com>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Glen Choo" <glencbz@gmail.com>, "Patrick Steinhardt" <ps@pks.im>
Subject: Re: [PATCH v4 2/2] fetch: add fetch.submoduleErrors to make submodule fetch errors non-fatal
Date: Tue, 14 Jul 2026 08:34:26 -0700 [thread overview]
Message-ID: <xmqqldbdvb3x.fsf@gitster.g> (raw)
In-Reply-To: <20260714132959.3368867-3-paulius.zaleckas@gmail.com> (Paulius Zaleckas's message of "Tue, 14 Jul 2026 16:29:57 +0300")
Paulius Zaleckas <paulius.zaleckas@gmail.com> writes:
> t/t5526-fetch-submodules.sh | 89 ++++++++++++++++++++++++++++++++
> 6 files changed, 168 insertions(+), 4 deletions(-)
In addition to what was pointed out by Ramsay in his squashable
patch <387a34d5-fdf5-4513-9aaf-4e73d9304c1d@ramsayjones.plus.com>
this round adds another use of raw grep that is caught by the test
framework.
commit 8f7761ee72b3669c1aee98142852437d016c785c
Author: Junio C Hamano <gitster@pobox.com>
Date: Tue Jul 14 08:31:57 2026 -0700
fixup! fetch: add fetch.submoduleErrors to make submodule fetch errors non-fatal
diff --git a/t/t5526-fetch-submodules.sh b/t/t5526-fetch-submodules.sh
index 614d45ab71..19d17440cf 100755
--- a/t/t5526-fetch-submodules.sh
+++ b/t/t5526-fetch-submodules.sh
@@ -1408,7 +1408,7 @@ test_expect_success '--submodule-errors=fail overrides warn config for fetch --a
git -C env_override/clone config fetch.submoduleErrors warn &&
test_must_fail git -C env_override/clone fetch --all --recurse-submodules \
--submodule-errors=fail 2>err &&
- grep "Errors during submodule fetch" err
+ test_grep "Errors during submodule fetch" err
'
test_expect_success 'fetch.submoduleErrors=warn: inaccessible submodule is non-fatal' '
next prev parent reply other threads:[~2026-07-14 15:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 12:26 [PATCH v3 0/2] fetch: make submodule fetch errors configurable Paulius Zaleckas
2026-07-10 12:26 ` [PATCH v3 1/2] submodule: fix premature failure in recursive submodule fetch Paulius Zaleckas
2026-07-10 12:26 ` [PATCH v3 2/2] fetch: add fetch.submoduleErrors to make submodule fetch errors non-fatal Paulius Zaleckas
2026-07-10 22:21 ` Junio C Hamano
2026-07-14 13:29 ` Paulius Zaleckas
2026-07-14 13:29 ` [PATCH v4 0/2] fetch: make submodule fetch errors configurable Paulius Zaleckas
2026-07-14 13:29 ` [PATCH v4 1/2] submodule: fix premature failure in recursive submodule fetch Paulius Zaleckas
2026-07-14 13:29 ` [PATCH v4 2/2] fetch: add fetch.submoduleErrors to make submodule fetch errors non-fatal Paulius Zaleckas
2026-07-14 15:34 ` Junio C Hamano [this message]
2026-07-14 17:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqldbdvb3x.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=glencbz@gmail.com \
--cc=paulius.zaleckas@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.