From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Harald Nordgren via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Harald Nordgren <haraldnordgren@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v3] config.mak.uname: avoid macOS dup-library warning
Date: Mon, 22 Jun 2026 05:57:03 -0700 [thread overview]
Message-ID: <xmqqldc63f8g.fsf@gitster.g> (raw)
In-Reply-To: <ajjspU7lJ01GgrBw@pks.im> (Patrick Steinhardt's message of "Mon, 22 Jun 2026 10:04:53 +0200")
Patrick Steinhardt <ps@pks.im> writes:
>> Yeah, this looks like what I expected.
>>
>> A few things to note.
>>
>> * Can folks with different versions of Xcode (or is 15 sufficiently
>> old that practically nobody is expected to have anything older?)
>> test this patch?
>>
>> * We only patch Makefile here; can folks who use meson report how
>> well your build goes?
>
> When using Meson we also see a warning. This got partially fixed in
> Meson itself though via [1], where it started to disable the warning
> when compiling with "--fatal-warnings" so that it doesn't cause builds
> to break. So starting with that commit it really only is a harmless
> (albeit annoying) warning.
>
> Arguably, it might make sense to unconditionally disable this warning,
> as it doesn't seem to add anything of value. I've Cc'd Paolo, one of the
> Meson maintainers.
>
> Thanks!
>
> Patrick
>
> [1]: https://github.com/mesonbuild/meson/commit/17d1cc60ed8246b8e7f0786421bf1cdf5cb19254
I took my inspiration for -Wl,-no-whatever from Paolo's other
attempt, referenced in
https://github.com/mesonbuild/meson/issues/15553
which is
https://github.com/mesonbuild/meson/commit/7c901d7a8af214e31788eb6d1a1edd5b75124e66
next prev parent reply other threads:[~2026-06-22 12:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-31 23:16 [PATCH] Makefile: drop duplicate %.a from link recipes Harald Nordgren via GitGitGadget
2026-06-04 0:33 ` Junio C Hamano
2026-06-04 7:06 ` Harald Nordgren
2026-06-04 7:15 ` Harald Nordgren
2026-06-04 22:03 ` [PATCH v2] Makefile: dedup archives in $(LIBS) so link recipes don't repeat them Harald Nordgren via GitGitGadget
2026-06-10 13:24 ` Harald Nordgren
2026-06-19 8:00 ` Harald Nordgren
2026-06-19 15:41 ` Junio C Hamano
2026-06-19 20:25 ` Harald Nordgren
2026-06-19 20:32 ` [PATCH v3] config.mak.uname: avoid macOS dup-library warning Harald Nordgren via GitGitGadget
2026-06-19 22:27 ` Junio C Hamano
2026-06-20 20:58 ` D. Ben Knoble
2026-06-22 15:49 ` D. Ben Knoble
2026-06-22 8:04 ` Patrick Steinhardt
2026-06-22 12:57 ` Junio C Hamano [this message]
2026-06-22 13:13 ` Paolo Bonzini
2026-06-22 13:36 ` Patrick Steinhardt
2026-06-22 14:00 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqldc63f8g.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=haraldnordgren@gmail.com \
--cc=pbonzini@redhat.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.