From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, christian.couder@gmail.com,
johannes.schindelin@gmx.de, johncai86@gmail.com,
karthik.188@gmail.com, kristofferhaugsbakk@fastmail.com,
newren@gmail.com, peff@peff.net, ps@pks.im,
Derrick Stolee <stolee@gmail.com>
Subject: Re: [PATCH v5 00/13] pack-objects: integrate --path-walk and some --filter options
Date: Mon, 25 May 2026 08:44:17 +0900 [thread overview]
Message-ID: <xmqqldd8gypa.fsf@gitster.g> (raw)
In-Reply-To: <ahDbS+CtwsGx62Q3@nand.local> (Taylor Blau's message of "Fri, 22 May 2026 18:40:11 -0400")
Taylor Blau <me@ttaylorr.com> writes:
> On Fri, May 22, 2026 at 06:24:24PM +0000, Derrick Stolee via GitGitGadget wrote:
>> Range-diff vs v4:
>>
>> 1: 0840110116 = 1: 0840110116 t5620: make test work with path-walk var
>> 2: d7c87545f3 = 2: d7c87545f3 pack-objects: pass --objects with --path-walk
>> 3: fb8a0f9c43 ! 3: 697ef716d2 t/perf: add pack-objects filter and path-walk benchmark
>> @@ t/perf/p5315-pack-objects-filter.sh (new)
>> + awk "{print \$4;}" >top-dirs &&
>> + top_nr=$(wc -l <top-dirs) &&
>> +
>> -+ >depth2-dirs &&
>> + while read tdir
>> + do
>> -+ git ls-tree -d --name-only "HEAD:$tdir" 2>/dev/null || return 1
>> -+ done <top-dirs >depth2-dirs.raw &&
>> -+ sed "s|^|$tdir/|" <depth2-dirs.raw >depth2-dirs &&
>> ++ git ls-tree -d --format="$tdir/%(path)" "HEAD:$tdir" || return 1
>> ++ done <top-dirs >depth2-dirs &&
>> +
>> + d2_nr=$(wc -l <depth2-dirs) &&
>> +
>> 4: e77c8a6bbc = 4: 91845bcef0 path-walk: always emit directly-requested objects
>> 5: f4904f81e0 = 5: fdb9361198 path-walk: support blobless filter
>> 6: f37467e46f = 6: 89726faf7e backfill: die on incompatible filter options
>> 7: 133c1b156c = 7: 3884d4737f path-walk: support blob size limit filter
>> 8: 0f517be8e3 = 8: 31b4ef0fa1 path-walk: add pl_sparse_trees to control tree pruning
>> 9: b4dc09ab69 = 9: 7d8f0aa036 pack-objects: support sparse:oid filter with path-walk
>> 10: 0b1eed0790 = 10: a68676d0de t6601: tag otherwise-unreachable trees
>> 11: b23244c4c2 = 11: b0db73c6cc path-walk: support `tree:0` filter
>> 12: 7e1e503361 = 12: 6845988f50 path-walk: support `object:type` filter
>> 13: a615b1a707 = 13: d33d899251 path-walk: support `combine` filter
>
> The range-diff looks good to me. Thanks!
Good. And as you in <ahDbS+CtwsGx62Q3@nand.local> were already
happy with everything else in the previous iteration of this series,
not just the changes the range-diff output shows, but also the
non-changes from the previous iteration, look good to you ;-).
Let's mark the topic for 'next'. Thanks, both.
prev parent reply other threads:[~2026-05-24 23:44 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-02 14:15 [PATCH 0/7] pack-objects: integrate --path-walk and some --filter options Derrick Stolee via GitGitGadget
2026-05-02 14:15 ` [PATCH 1/7] pack-objects: pass --objects with --path-walk Derrick Stolee via GitGitGadget
2026-05-04 0:49 ` Junio C Hamano
2026-05-04 12:01 ` Derrick Stolee
2026-05-02 14:15 ` [PATCH 2/7] t/perf: add pack-objects filter and path-walk benchmark Derrick Stolee via GitGitGadget
2026-05-02 14:15 ` [PATCH 3/7] path-walk: support blobless filter Derrick Stolee via GitGitGadget
2026-05-02 14:15 ` [PATCH 4/7] backfill: die on incompatible filter options Derrick Stolee via GitGitGadget
2026-05-03 22:59 ` Junio C Hamano
2026-05-04 12:09 ` Derrick Stolee
2026-05-02 14:15 ` [PATCH 5/7] path-walk: support blob size limit filter Derrick Stolee via GitGitGadget
2026-05-02 14:15 ` [PATCH 6/7] path-walk: add pl_sparse_trees to control tree pruning Derrick Stolee via GitGitGadget
2026-05-02 14:15 ` [PATCH 7/7] pack-objects: support sparse:oid filter with path-walk Derrick Stolee via GitGitGadget
2026-05-04 20:21 ` [PATCH v2 00/10] pack-objects: integrate --path-walk and some --filter options Derrick Stolee via GitGitGadget
2026-05-04 20:21 ` [PATCH v2 01/10] pack-objects: pass --objects with --path-walk Derrick Stolee via GitGitGadget
2026-05-04 20:21 ` [PATCH v2 02/10] t/perf: add pack-objects filter and path-walk benchmark Derrick Stolee via GitGitGadget
2026-05-04 20:21 ` [PATCH v2 03/10] path-walk: support blobless filter Derrick Stolee via GitGitGadget
2026-05-04 20:21 ` [PATCH v2 04/10] backfill: die on incompatible filter options Derrick Stolee via GitGitGadget
2026-05-04 20:21 ` [PATCH v2 05/10] path-walk: support blob size limit filter Derrick Stolee via GitGitGadget
2026-05-04 20:21 ` [PATCH v2 06/10] path-walk: add pl_sparse_trees to control tree pruning Derrick Stolee via GitGitGadget
2026-05-04 20:21 ` [PATCH v2 07/10] pack-objects: support sparse:oid filter with path-walk Derrick Stolee via GitGitGadget
2026-05-04 20:21 ` [PATCH v2 08/10] path-walk: support `tree:0` filter Taylor Blau via GitGitGadget
2026-05-04 20:21 ` [PATCH v2 09/10] path-walk: support `object:type` filter Taylor Blau via GitGitGadget
2026-05-04 20:21 ` [PATCH v2 10/10] path-walk: support `combine` filter Taylor Blau via GitGitGadget
2026-05-05 16:18 ` [PATCH v2 00/10] pack-objects: integrate --path-walk and some --filter options Derrick Stolee
2026-05-05 19:01 ` Taylor Blau
2026-05-05 19:44 ` Derrick Stolee
2026-05-05 20:42 ` Taylor Blau
2026-05-07 11:40 ` Derrick Stolee
2026-05-11 3:05 ` Junio C Hamano
2026-05-11 13:58 ` Derrick Stolee
2026-05-11 18:12 ` [PATCH v3 00/12] " Derrick Stolee via GitGitGadget
2026-05-11 18:12 ` [PATCH v3 01/12] t5620: make test work with path-walk var Derrick Stolee via GitGitGadget
2026-05-12 1:03 ` Taylor Blau
2026-05-11 18:12 ` [PATCH v3 02/12] pack-objects: pass --objects with --path-walk Derrick Stolee via GitGitGadget
2026-05-12 1:04 ` Taylor Blau
2026-05-11 18:13 ` [PATCH v3 03/12] t/perf: add pack-objects filter and path-walk benchmark Derrick Stolee via GitGitGadget
2026-05-12 1:11 ` Taylor Blau
2026-05-13 18:23 ` Derrick Stolee
2026-05-11 18:13 ` [PATCH v3 04/12] path-walk: always emit directly-requested objects Derrick Stolee via GitGitGadget
2026-05-12 1:23 ` Taylor Blau
2026-05-13 18:29 ` Derrick Stolee
2026-05-11 18:13 ` [PATCH v3 05/12] path-walk: support blobless filter Derrick Stolee via GitGitGadget
2026-05-11 18:38 ` Taylor Blau
2026-05-11 19:44 ` Derrick Stolee
2026-05-11 18:13 ` [PATCH v3 06/12] backfill: die on incompatible filter options Derrick Stolee via GitGitGadget
2026-05-12 1:26 ` Taylor Blau
2026-05-11 18:13 ` [PATCH v3 07/12] path-walk: support blob size limit filter Derrick Stolee via GitGitGadget
2026-05-12 1:33 ` Taylor Blau
2026-05-13 18:35 ` Derrick Stolee
2026-05-11 18:13 ` [PATCH v3 08/12] path-walk: add pl_sparse_trees to control tree pruning Derrick Stolee via GitGitGadget
2026-05-11 18:13 ` [PATCH v3 09/12] pack-objects: support sparse:oid filter with path-walk Derrick Stolee via GitGitGadget
2026-05-11 18:13 ` [PATCH v3 10/12] path-walk: support `tree:0` filter Taylor Blau via GitGitGadget
2026-05-12 1:41 ` Taylor Blau
2026-05-13 19:46 ` Derrick Stolee
2026-05-11 18:13 ` [PATCH v3 11/12] path-walk: support `object:type` filter Taylor Blau via GitGitGadget
2026-05-11 18:13 ` [PATCH v3 12/12] path-walk: support `combine` filter Taylor Blau via GitGitGadget
2026-05-12 1:43 ` [PATCH v3 00/12] pack-objects: integrate --path-walk and some --filter options Taylor Blau
2026-05-13 21:18 ` [PATCH v4 00/13] " Derrick Stolee via GitGitGadget
2026-05-13 21:18 ` [PATCH v4 01/13] t5620: make test work with path-walk var Derrick Stolee via GitGitGadget
2026-05-13 21:18 ` [PATCH v4 02/13] pack-objects: pass --objects with --path-walk Derrick Stolee via GitGitGadget
2026-05-13 21:18 ` [PATCH v4 03/13] t/perf: add pack-objects filter and path-walk benchmark Derrick Stolee via GitGitGadget
2026-05-19 23:51 ` Taylor Blau
2026-05-21 22:56 ` Derrick Stolee
2026-05-13 21:18 ` [PATCH v4 04/13] path-walk: always emit directly-requested objects Derrick Stolee via GitGitGadget
2026-05-19 23:22 ` Taylor Blau
2026-05-21 23:00 ` Derrick Stolee
2026-05-22 16:36 ` Taylor Blau
2026-05-13 21:18 ` [PATCH v4 05/13] path-walk: support blobless filter Derrick Stolee via GitGitGadget
2026-05-13 21:18 ` [PATCH v4 06/13] backfill: die on incompatible filter options Derrick Stolee via GitGitGadget
2026-05-13 21:18 ` [PATCH v4 07/13] path-walk: support blob size limit filter Derrick Stolee via GitGitGadget
2026-05-13 21:18 ` [PATCH v4 08/13] path-walk: add pl_sparse_trees to control tree pruning Derrick Stolee via GitGitGadget
2026-05-13 21:18 ` [PATCH v4 09/13] pack-objects: support sparse:oid filter with path-walk Derrick Stolee via GitGitGadget
2026-05-13 21:18 ` [PATCH v4 10/13] t6601: tag otherwise-unreachable trees Derrick Stolee via GitGitGadget
2026-05-13 21:18 ` [PATCH v4 11/13] path-walk: support `tree:0` filter Taylor Blau via GitGitGadget
2026-05-13 21:18 ` [PATCH v4 12/13] path-walk: support `object:type` filter Taylor Blau via GitGitGadget
2026-05-13 21:18 ` [PATCH v4 13/13] path-walk: support `combine` filter Taylor Blau via GitGitGadget
2026-05-19 23:53 ` [PATCH v4 00/13] pack-objects: integrate --path-walk and some --filter options Taylor Blau
2026-05-21 23:01 ` Derrick Stolee
2026-05-22 16:37 ` Taylor Blau
2026-05-22 18:24 ` Derrick Stolee
2026-05-22 18:24 ` [PATCH v5 " Derrick Stolee via GitGitGadget
2026-05-22 18:24 ` [PATCH v5 01/13] t5620: make test work with path-walk var Derrick Stolee via GitGitGadget
2026-05-22 18:24 ` [PATCH v5 02/13] pack-objects: pass --objects with --path-walk Derrick Stolee via GitGitGadget
2026-05-22 18:24 ` [PATCH v5 03/13] t/perf: add pack-objects filter and path-walk benchmark Derrick Stolee via GitGitGadget
2026-05-22 18:24 ` [PATCH v5 04/13] path-walk: always emit directly-requested objects Derrick Stolee via GitGitGadget
2026-05-22 18:24 ` [PATCH v5 05/13] path-walk: support blobless filter Derrick Stolee via GitGitGadget
2026-05-22 18:24 ` [PATCH v5 06/13] backfill: die on incompatible filter options Derrick Stolee via GitGitGadget
2026-05-22 18:24 ` [PATCH v5 07/13] path-walk: support blob size limit filter Derrick Stolee via GitGitGadget
2026-05-22 18:24 ` [PATCH v5 08/13] path-walk: add pl_sparse_trees to control tree pruning Derrick Stolee via GitGitGadget
2026-05-22 18:24 ` [PATCH v5 09/13] pack-objects: support sparse:oid filter with path-walk Derrick Stolee via GitGitGadget
2026-05-22 18:24 ` [PATCH v5 10/13] t6601: tag otherwise-unreachable trees Derrick Stolee via GitGitGadget
2026-05-22 18:24 ` [PATCH v5 11/13] path-walk: support `tree:0` filter Taylor Blau via GitGitGadget
2026-05-22 18:24 ` [PATCH v5 12/13] path-walk: support `object:type` filter Taylor Blau via GitGitGadget
2026-05-22 18:24 ` [PATCH v5 13/13] path-walk: support `combine` filter Taylor Blau via GitGitGadget
2026-05-22 22:40 ` [PATCH v5 00/13] pack-objects: integrate --path-walk and some --filter options Taylor Blau
2026-05-24 23:44 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqldd8gypa.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=johncai86@gmail.com \
--cc=karthik.188@gmail.com \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=me@ttaylorr.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.