All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Greg Hurrell via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,  Jeff King <peff@peff.net>,
	 Greg Hurrell <greg@hurrell.net>,
	 Erik Cervin Edin <erik@cervined.in>,
	 Greg Hurrell <greg.hurrell@datadoghq.com>
Subject: Re: [PATCH v3] git-jump: pick a mode automatically when invoked without arguments
Date: Thu, 21 May 2026 23:00:46 +0900	[thread overview]
Message-ID: <xmqqlddczwtt.fsf@gitster.g> (raw)
In-Reply-To: <pull.2108.v3.git.1779371110195.gitgitgadget@gmail.com> (Greg Hurrell via GitGitGadget's message of "Thu, 21 May 2026 13:45:09 +0000")

"Greg Hurrell via GitGitGadget" <gitgitgadget@gmail.com> writes:

>      * Removed stray # from README.
>      * Don't both teaching "auto" to select "ws" mode, because it is always
>        subsumed by "diff".
>      * Update usage string to make clear that git jump --stdout foo is not a
>        synonym for git jump --stdout auto foo, because distinguishing
>        between foo as <mode> and foo as <arg> is fraught with ambiguity.
>     
>     In answer to Junio's question:
>     
>     > If more than one interesting cases apply, what happens, and what
>     > should happen?
>     
>     it's an ordered choice (merge > diff).

After 'diff --quiet "$@"' says "nothing interesting between the
index and the working tree", I actually think it may be worth using
either 'git diff --check HEAD "$@"' or 'git diff --cached --check "$@"'
to see if ws fix is needed.

But I am not a target audience of this feature, so I'll let others
figure out what to do here.

  reply	other threads:[~2026-05-21 14:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-08  9:07 [PATCH] git-jump: pick a mode automatically when invoked without arguments Greg Hurrell via GitGitGadget
2026-05-08 14:13 ` Jeff King
2026-05-08 14:30   ` Greg Hurrell
2026-05-08 17:52     ` Jeff King
2026-05-14 15:40       ` Erik Cervin Edin
2026-05-19  9:03         ` Greg Hurrell
2026-05-19 21:22           ` Jeff King
2026-05-20 12:31 ` [PATCH v2] " Greg Hurrell via GitGitGadget
2026-05-21  1:22   ` Junio C Hamano
2026-05-21  1:30     ` Junio C Hamano
2026-05-21 13:45   ` [PATCH v3] " Greg Hurrell via GitGitGadget
2026-05-21 14:00     ` Junio C Hamano [this message]
2026-05-22  5:28     ` Jeff King
2026-05-22  7:33       ` Greg Hurrell
2026-05-26 21:33       ` Erik Cervin Edin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqlddczwtt.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=erik@cervined.in \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=greg.hurrell@datadoghq.com \
    --cc=greg@hurrell.net \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.