All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Matthew Hughes <matthewhughes934@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] docs: note the type of core.attributesfile
Date: Thu, 18 Dec 2025 09:15:14 +0900	[thread overview]
Message-ID: <xmqqldj0zlv1.fsf@gitster.g> (raw)
In-Reply-To: <20251217195917.25710-1-matthewhughes934@gmail.com> (Matthew Hughes's message of "Wed, 17 Dec 2025 19:59:55 +0000")

Matthew Hughes <matthewhughes934@gmail.com> writes:

> This change is basically the same rewording as was done to
> 'core.excludesFile' in dca83abde2 (config: describe 'pathname' value
> type).

Indeed, when we look at Documentation/config.txt in the commit
immediately before that one, the description for core.excludesFile
and core.attributesFile starts quite similarly.  The old commit 
dca83abd (config: describe 'pathname' value type, 2016-04-29) should
have done this already back then when it touched core.excludesFile.

Will queue.  Thanks.


> Signed-off-by: Matthew Hughes <matthewhughes934@gmail.com>
> ---
>  Documentation/config/core.adoc | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/config/core.adoc b/Documentation/config/core.adoc
> index 01202da7cd..9bc9de29d9 100644
> --- a/Documentation/config/core.adoc
> +++ b/Documentation/config/core.adoc
> @@ -492,10 +492,9 @@ core.askPass::
>  	command-line argument and write the password on its STDOUT.
>  
>  core.attributesFile::
> -	In addition to `.gitattributes` (per-directory) and
> -	`.git/info/attributes`, Git looks into this file for attributes
> -	(see linkgit:gitattributes[5]). Path expansions are made the same
> -	way as for `core.excludesFile`. Its default value is
> +	Specifies the pathname to the file that contains attributes (see
> +	linkgit:gitattributes[5]), in addition to `.gitattributes` (per-directory)
> +	and `.git/info/attributes`. Its default value is
>  	`$XDG_CONFIG_HOME/git/attributes`. If `$XDG_CONFIG_HOME` is either not
>  	set or empty, `$HOME/.config/git/attributes` is used instead.

      reply	other threads:[~2025-12-18  0:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-17 19:51 [PATCH] docs: note the type of core.attributesfile Matthew Hughes
2025-12-17 19:53 ` Matthew Hughes
2025-12-17 19:59 ` [PATCH v2] " Matthew Hughes
2025-12-18  0:15   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqldj0zlv1.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=matthewhughes934@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.