All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Cc: git@vger.kernel.org,  brad@comstyle.com,  collin.funk1@gmail.com,
	pclouds@gmail.com,  ps@pks.im
Subject: Re: [PATCH v5] builtin/gc: correct total_ram calculation with HAVE_BSD_SYSCTL
Date: Mon, 07 Jul 2025 10:09:43 -0700	[thread overview]
Message-ID: <xmqqldp03p2g.fsf@gitster.g> (raw)
In-Reply-To: <20250707164518.6600-1-carenas@gmail.com> ("Carlo Marcelo Arenas Belón"'s message of "Mon, 7 Jul 2025 09:45:18 -0700")

Carlo Marcelo Arenas Belón <carenas@gmail.com> writes:

> The calls to sysctl() assume a 64-bit memory size for the variable
> holding the value, but the actual size depends on the key name and
> platform, at least for HW_PHYSMEM.
>
> Detect any mismatched reads, and retry with a shorter variable
> when needed.
>
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
> ---
>  builtin/gc.c | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)

Thanks.  Let's declare victory and merge this to 'next'.


      reply	other threads:[~2025-07-07 17:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-02 14:42 [PATCH] builtin/gc: improve total_ram calculation for HAVE_BSD_SYSCTL Carlo Marcelo Arenas Belón
2025-07-02 15:23 ` Patrick Steinhardt
2025-07-02 17:04   ` Carlo Marcelo Arenas Belón
2025-07-02 15:46 ` [PATCH v2] builtin/gc: protect against sysctl() failure in total_ram Carlo Marcelo Arenas Belón
2025-07-02 18:42   ` Junio C Hamano
2025-07-02 20:22     ` Carlo Marcelo Arenas Belón
2025-07-02 20:59       ` Junio C Hamano
2025-07-02 20:21   ` [PATCH v3] builtin/gc: correct total_ram calculation with HAVE_BSD_SYSCTL Carlo Marcelo Arenas Belón
2025-07-02 21:14     ` Junio C Hamano
2025-07-02 22:42       ` Carlo Marcelo Arenas Belón
2025-07-02 22:59         ` Junio C Hamano
2025-07-03  8:01     ` [PATCH v4] " Carlo Marcelo Arenas Belón
2025-07-07 13:39       ` Junio C Hamano
2025-07-07 16:45       ` [PATCH v5] " Carlo Marcelo Arenas Belón
2025-07-07 17:09         ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqldp03p2g.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=brad@comstyle.com \
    --cc=carenas@gmail.com \
    --cc=collin.funk1@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.