All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Sampriyo Guin via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org,  "Patrick Steinhardt [ ]" <ps@pks.im>,
	 "Karthik Nayak [ ]" <karthik.188@gmail.com>,
	 "Jialuo She [ ]" <shejialuo@gmail.com>,
	 "Christian Couder [ ]" <christian.couder@gmail.com>,
	 "Ghanshyam Thakkar [ ]" <shyamthakkar001@gmail.com>,
	 Sampriyo Guin <sampriyoguin@gmail.com>
Subject: Re: [PATCH] [GSoC Patch] Modernize Test Path Checking in Git’s Test Suite
Date: Tue, 18 Mar 2025 16:53:49 -0700	[thread overview]
Message-ID: <xmqqldt1zyia.fsf@gitster.g> (raw)
In-Reply-To: <CAPig+cSXiKOBq_+9+uDTFOLf5F8+KPocwXVX2VzPQAxJHQL99w@mail.gmail.com> (Eric Sunshine's message of "Tue, 18 Mar 2025 17:49:24 -0400")

Eric Sunshine <sunshine@sunshineco.com> writes:

> Referring to the other thread at [*], perhaps this (avoiding `!` in
> front of test_path_*) is yet another clarification which ought to be
> added to the microproject description in order to lead candidates in a
> more profitable direction.
>
> [*]: https://lore.kernel.org/git/CAPig+cRm+sc+Rk-4SuQ5CrPeZLG2Nzz9B7+6OZxCq7tV5mzmBA@mail.gmail.com/

While mentors do that, I'd prefer to see others extend support for 

	test_path_is_file ! this-should-not-be-file

so that the students have a better tool to work with.

> One other recommendation I would make is to restrict the microproject
> submission to just a single test script (rather than updating twelve
> of them) in order to avoid exhausting the pool for other potential
> candidates.

Yes, you made that point in the other thread, and I agree with it
100%.

Thanks.

  reply	other threads:[~2025-03-18 23:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-18 20:26 [PATCH] [GSoC Patch] Modernize Test Path Checking in Git’s Test Suite Sampriyo Guin via GitGitGadget
2025-03-18 21:14 ` Junio C Hamano
2025-03-18 21:49   ` Eric Sunshine
2025-03-18 23:53     ` Junio C Hamano [this message]
2025-03-19  6:03 ` [PATCH v2] [GSoC Patch v2]Modernize Test Path Checking: test -(e|f|d) Sampriyo Guin via GitGitGadget
  -- strict thread matches above, loose matches on Subject: below --
2025-03-03 14:18 [PATCH] [GSOC][PATCH] Modernize Test Path Checking in Git’s Test Suite Prachit Ingle
2025-03-03 20:04 ` Mahendra Dani
2025-03-03 20:57 ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqldt1zyia.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=karthik.188@gmail.com \
    --cc=ps@pks.im \
    --cc=sampriyoguin@gmail.com \
    --cc=shejialuo@gmail.com \
    --cc=shyamthakkar001@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.