Re: [PATCH 3/3] completion: fix bugs with slashes in remote names

[Junio C Hamano <gitster@pobox.com>]

"D. Ben Knoble" <ben.knoble@gmail.com> writes:

> On Mon, Mar 3, 2025 at 2:25 PM David Mandelberg <david@mandelberg.org> wrote:
>>
>> > Thanks, I'm not familiar with bash's extensions to parameter
>> > substitution. The completions can also but used under zsh (git-
>> > completion.zsh is pretty much abandoned I think) but it looks like bash
>> > and zsh agree on this expansion.
>
> I don't think "abandoned" is the right characterization—at least, it's
> the completion script that Homebrew-installed Git users will get for
> Zsh, and it does re-use the Bash completion scripts (which therefore
> ought to stay portable between both if possible, otherwise we get
> stuff like 8776470cf3 (completion: repair config completion for Zsh,
> 2025-01-06)). The Zsh script has seen some fixups over time (such as
> my own 3c20acdf46 (completion: zsh: stop leaking local cache variable,
> 2024-04-30)).

Thanks for clarifying.

>> The tests don't automatically run under zsh though, right? Maybe I
>> should try to figure out how to do that in a separate patch...
>
> Correct—which is how bugs sneak in ;)
>
> I'm willing to manually test the patch if I can understand how to
> reproduce the issue—it sounds like having a remote name with a slash
> is sufficient?
>
> I started trying to test Zsh completion a while back when working on
> one of the patches mentioned above; I got as far as this hack [1],
> which is to say, not very far at all.

Thanks.