All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jonas 'Sortie' Termansen <sortie@maxsi.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Makefile: don't remove configure on distclean
Date: Tue, 05 Nov 2024 10:35:18 -0800	[thread overview]
Message-ID: <xmqqldxxsf4p.fsf@gitster.g> (raw)
In-Reply-To: <76f4dfe6-3724-472b-9b42-c91926e61fd1@maxsi.org> (Jonas Termansen's message of "Tue, 5 Nov 2024 11:13:49 +0100")

Jonas 'Sortie' Termansen <sortie@maxsi.org> writes:

> make distclean conventionally restores the extracted release tarball to
> its original distributed contents by cleaning the source code for
> distribution. However, the configure script is part of the distribution
> and should not be removed. This behavior is creating problems on my
> package infrastructure where configure-based packages have make
> distclean run afterwards and then the subsequent git build fails.

Without a target that truly cleans any build artifacts over what is
recorded in the commit to replace "make distclean", this is a
regression.  It seems people use "make reallyclean" or something for
that, perhaps?

> Signed-off-by: Jonas 'Sortie' Termansen <sortie@maxsi.org>
> ---
>  Makefile | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 6f5986b66e..c488b914a0 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -3723,7 +3723,6 @@ dist-doc: git$X
>  ### Cleaning rules
>  
>  distclean: clean
> -	$(RM) configure
>  	$(RM) config.log config.status config.cache
>  	$(RM) config.mak.autogen config.mak.append
>  	$(RM) -r autom4te.cache

  reply	other threads:[~2024-11-05 18:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-05 10:13 [PATCH] Makefile: don't remove configure on distclean Jonas 'Sortie' Termansen
2024-11-05 18:35 ` Junio C Hamano [this message]
2024-11-05 19:58   ` [PATCH v2] " Jonas 'Sortie' Termansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqldxxsf4p.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=sortie@maxsi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.