From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: Patrick Steinhardt <ps@pks.im>,
git@vger.kernel.org, Derrick Stolee <stolee@gmail.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Emily Shaffer <nasamuffin@google.com>
Subject: Re: [PATCH] BreakingChanges: early adopter option
Date: Thu, 26 Sep 2024 09:25:59 -0700 [thread overview]
Message-ID: <xmqqldzel6ug.fsf@gitster.g> (raw)
In-Reply-To: <02d7b805-f006-43ca-906e-fe9398b8ec35@gmail.com> (Phillip Wood's message of "Thu, 26 Sep 2024 15:16:09 +0100")
Phillip Wood <phillip.wood123@gmail.com> writes:
>> One problem with runtime toggles are commands that go away
>> entirely. We
>> can of course hide them away in various different places and make it
>> impossible to call them. But one of the downsides is that it is not
>> "true" to the actual removal, as for example the dashed builtins may
>> still exist.
>
> We should be able to make sure those dashed builtins fail though,
> while that isn't exactly the same as the command not existing it would
> signal that the command does not work in git3.
Yes, that is what Patrick means by "we can of course hide" and what
I meant by "it is more costly for developers to do it at runtime".
> Yes, it's hard to see many people doing that, though if we're lucky
> some companies that build their own git will test the git3 build. It's
> also hard to judge how many people would turn on the config option -
> if we go with that route we could be doing (a lot?) of extra work for
> not much benefit.
That is certainly a thing worth considering.
next prev parent reply other threads:[~2024-09-26 16:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 19:33 [PATCH] BreakingChanges: early adopter option Junio C Hamano
2024-09-20 21:33 ` Junio C Hamano
2024-09-22 17:51 ` Junio C Hamano
2024-09-26 11:57 ` Patrick Steinhardt
2024-09-26 14:16 ` Phillip Wood
2024-09-26 16:25 ` Junio C Hamano [this message]
2024-09-26 16:26 ` Junio C Hamano
2024-09-26 15:57 ` Junio C Hamano
2024-10-11 21:49 ` [PATCH v2] " Junio C Hamano
2024-10-16 7:22 ` Patrick Steinhardt
2024-10-16 22:07 ` Taylor Blau
2025-02-28 17:28 ` Re* " Junio C Hamano
2025-03-03 10:30 ` Patrick Steinhardt
2025-03-03 16:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqldzel6ug.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=nasamuffin@google.com \
--cc=phillip.wood123@gmail.com \
--cc=ps@pks.im \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.