From: Junio C Hamano <gitster@pobox.com>
To: Dragan Simic <dsimic@manjaro.org>
Cc: git@vger.kernel.org, code@khaugsbakk.name
Subject: Re: [PATCH v4] documentation: send-email: use camel case consistently
Date: Tue, 20 Feb 2024 14:57:25 -0800 [thread overview]
Message-ID: <xmqqle7elp62.fsf@gitster.g> (raw)
In-Reply-To: <88f1fe08c3047e14090957093ee8d98b0f60cb6c.1708467601.git.dsimic@manjaro.org> (Dragan Simic's message of "Tue, 20 Feb 2024 23:22:51 +0100")
Dragan Simic <dsimic@manjaro.org> writes:
> -sendemail.smtpsslcertpath::
> +sendemail.smtpSSLCertPath::
> -sendemail.signedoffbycc::
> +sendemail.signedOffByCc::
> -sendemail.suppresscc::
> +sendemail.suppressCc::
> -sendemail.tocmd::
> +sendemail.toCmd::
> -sendemail.signedoffcc (deprecated)::
> - Deprecated alias for `sendemail.signedoffbycc`.
> +sendemail.signedOffCc (deprecated)::
> + Deprecated alias for `sendemail.signedOffByCc`.
All look good.
> diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
> index d1ef6a204e68..8264f8738093 100644
> --- a/Documentation/git-send-email.txt
> +++ b/Documentation/git-send-email.txt
> @@ -138,7 +138,7 @@ Note that no attempts whatsoever are made to validate the encoding.
>
> --compose-encoding=<encoding>::
> Specify encoding of compose message. Default is the value of the
> - 'sendemail.composeencoding'; if that is unspecified, UTF-8 is assumed.
> + 'sendemail.composeEncoding'; if that is unspecified, UTF-8 is assumed.
Good.
> @@ -174,7 +174,7 @@ Sending
> Specify a command to run to send the email. The command should
> be sendmail-like; specifically, it must support the `-i` option.
> The command will be executed in the shell if necessary. Default
> - is the value of `sendemail.sendmailcmd`. If unspecified, and if
> + is the value of `sendemail.sendmailCmd`. If unspecified, and if
Good.
> @@ -269,7 +269,7 @@ must be used for each option.
> certificates concatenated together: see verify(1) -CAfile and
> -CApath for more information on these). Set it to an empty string
> to disable certificate verification. Defaults to the value of the
> - `sendemail.smtpsslcertpath` configuration variable, if set, or the
> + `sendemail.smtpSSLCertPath` configuration variable, if set, or the
Good.
> @@ -313,7 +313,7 @@ Automating
> Specify a command to execute once per patch file which
> should generate patch file specific "To:" entries.
> Output of this command must be single email address per line.
> - Default is the value of 'sendemail.tocmd' configuration value.
> + Default is the value of 'sendemail.toCmd' configuration value.
Good.
> - cc list. Default is the value of `sendemail.signedoffbycc` configuration
> + cc list. Default is the value of `sendemail.signedOffByCc` configuration
Good.
> - for each email set. Default is the value of 'sendemail.cccover'
> + for each email set. Default is the value of 'sendemail.ccCover'
Good.
> - for each email set. Default is the value of 'sendemail.tocover'
> + for each email set. Default is the value of 'sendemail.toCover'
Good.
> -Default is the value of `sendemail.suppresscc` configuration value; if
> +Default is the value of `sendemail.suppressCc` configuration value; if
Good.
> - See 'sendemail.aliasesfile' for more information about aliases.
> + See 'sendemail.aliasesFile' for more information about aliases.
Good.
This version looks very good to me. Thanks. Will queue.
next prev parent reply other threads:[~2024-02-20 22:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 22:22 [PATCH v4] documentation: send-email: use camel case consistently Dragan Simic
2024-02-20 22:57 ` Junio C Hamano [this message]
2024-02-21 0:04 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqle7elp62.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=code@khaugsbakk.name \
--cc=dsimic@manjaro.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.