From: Junio C Hamano <gitster@pobox.com>
To: "Kristoffer Haugsbakk" <code@khaugsbakk.name>
Cc: "Ben Dooks" <ben.dooks@codethink.co.uk>, git@vger.kernel.org
Subject: Re: [PATCH] send-email: add --compose-cover option
Date: Thu, 12 Oct 2023 13:31:22 -0700 [thread overview]
Message-ID: <xmqqlec7mvl1.fsf@gitster.g> (raw)
In-Reply-To: <277a80c5-40c9-4f1e-a68f-96673380012b@app.fastmail.com> (Kristoffer Haugsbakk's message of "Thu, 12 Oct 2023 22:03:23 +0200")
"Kristoffer Haugsbakk" <code@khaugsbakk.name> writes:
> 2. This would be really useful in `format-patch`. One could write the
> cover letter immediately instead of either (1) editing the generated
> one (placeholders) or (2) providing a file.
> - Personally I don't use `send-email` immediately—I use `format-patch`
> to generate everything so that I can review it before any
> sending. But there are many different workflows.
Hmph, I am not sure why a format-patch user would bother with the
"--compose-cover" option for the cover letter, to be honest. I am a
format-patch user and never drive it from send-email, just like the
workflow you use, and the norm to me is to review everything, not
just the cover letter but also the patches, in my editor session.
You apparently do not need "--edit-patches" option to review and
adjust as needed before sending, even though that is what you do
already. Why do you need a "--compose-cover" option?
next prev parent reply other threads:[~2023-10-12 20:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 11:27 [PATCH] send-email: add --compose-cover option Ben Dooks
2023-10-12 13:07 ` Ben Dooks
2023-10-12 20:03 ` Kristoffer Haugsbakk
2023-10-12 20:31 ` Junio C Hamano [this message]
2023-10-12 20:48 ` Kristoffer Haugsbakk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlec7mvl1.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ben.dooks@codethink.co.uk \
--cc=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.