From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: David Caro <dcaro@wikimedia.org>, git@vger.kernel.org
Subject: Re: Skipping adding Signed-off-by even if it's not the last on git commit
Date: Wed, 07 Dec 2022 13:11:16 +0900 [thread overview]
Message-ID: <xmqqlenj7t0b.fsf@gitster.g> (raw)
In-Reply-To: <Y4/xSObs9QXvE+xR@nand.local> (Taylor Blau's message of "Tue, 6 Dec 2022 20:50:00 -0500")
Taylor Blau <me@ttaylorr.com> writes:
>> I propose enabling it for commit, merge and am.
>
> So I think that there are some legitimate uses outside of 'format-patch'
> that we may want to keep the existing behavior. So I don't think we
> should necessarily change the default to have other commands outside of
> 'format-patch' start passing APPEND_SIGNOFF_DEDUP.
>
> But I could see a future where we add a new option that controls whether
> or not we pass that flag, perhaps:
>
> $ git commit --signoff[=[no-]dedup]
That sounds sensible.
next prev parent reply other threads:[~2022-12-07 4:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 17:06 Skipping adding Signed-off-by even if it's not the last on git commit David Caro
2022-12-07 1:50 ` Taylor Blau
2022-12-07 4:11 ` Junio C Hamano [this message]
2022-12-07 8:40 ` David Caro
2022-12-07 22:13 ` Taylor Blau
2022-12-07 23:04 ` Junio C Hamano
2022-12-08 7:27 ` Jeff King
2022-12-09 1:23 ` Junio C Hamano
2022-12-09 1:42 ` Jeff King
2022-12-09 4:03 ` Junio C Hamano
2022-12-09 20:39 ` Jeff King
2022-12-07 4:31 ` Ævar Arnfjörð Bjarmason
2022-12-07 4:57 ` Junio C Hamano
2022-12-07 15:00 ` Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlenj7t0b.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=dcaro@wikimedia.org \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.