All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Fernando Ramos <greenfoo@u92.eu>
Cc: Felipe Contreras <felipe.contreras@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v4 0/7] mergetools: vimdiff: regression fixes and improvements
Date: Wed, 10 Aug 2022 12:37:33 -0700	[thread overview]
Message-ID: <xmqqlervlwjm.fsf@gitster.g> (raw)
In-Reply-To: <YvP81vtZd7DlvQDa@zacax395.localdomain> (Fernando Ramos's message of "Wed, 10 Aug 2022 20:45:42 +0200")

Fernando Ramos <greenfoo@u92.eu> writes:

> On 22/08/10 10:46AM, Felipe Contreras wrote:
>> Hello,
>> 
>> These patches make vimdiff3 actually work, along with many single window
>> cases.
>> 
>
> Thanks Felipe. In this new v4 the code is even cleaner.
>
> I also manually re-tested all the cases (with and without .vimrc) and verified
> they work as expected.
>
> Reviewed-by: Fernando Ramos <greenfoo@u92.eu>
>
>
> PS to Junio: Is it OK to reply with "Reviewed-by" to the cover letter or (for
> the next time) should I had individually replied to each of the patches in the
> series? Thanks!

You did just fine.  I'll queue with your reviewed-by.

Thanks, both.


      reply	other threads:[~2022-08-10 19:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-10 15:46 [PATCH v4 0/7] mergetools: vimdiff: regression fixes and improvements Felipe Contreras
2022-08-10 15:46 ` [PATCH v4 1/7] mergetools: vimdiff: fix comment Felipe Contreras
2022-08-10 15:46 ` [PATCH v4 2/7] mergetools: vimdiff: make vimdiff3 actually work Felipe Contreras
2022-08-10 15:46 ` [PATCH v4 3/7] mergetools: vimdiff: silence annoying messages Felipe Contreras
2022-08-10 15:46 ` [PATCH v4 4/7] mergetools: vimdiff: fix for diffopt Felipe Contreras
2022-08-10 15:46 ` [PATCH v4 5/7] mergetools: vimdiff: rework tab logic Felipe Contreras
2022-08-10 15:46 ` [PATCH v4 6/7] mergetools: vimdiff: fix single window layouts Felipe Contreras
2022-08-10 15:46 ` [PATCH v4 7/7] mergetools: vimdiff: simplify tabfirst Felipe Contreras
2022-08-10 18:45 ` [PATCH v4 0/7] mergetools: vimdiff: regression fixes and improvements Fernando Ramos
2022-08-10 19:37   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqlervlwjm.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=greenfoo@u92.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.