From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>,
Han-Wen Nienhuys <hanwen@google.com>
Subject: Re: [PATCH 4/5] packed-backend: remove stub BUG(...) functions
Date: Thu, 17 Mar 2022 10:39:59 -0700 [thread overview]
Message-ID: <xmqqlex8h40g.fsf@gitster.g> (raw)
In-Reply-To: <patch-4.5-c9a7004bc38-20220317T171618Z-avarab@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Thu, 17 Mar 2022 18:27:18 +0100")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> - .for_each_reflog_ent = packed_for_each_reflog_ent,
> - .for_each_reflog_ent_reverse = packed_for_each_reflog_ent_reverse,
> - .reflog_exists = packed_reflog_exists,
> - .create_reflog = packed_create_reflog,
> - .delete_reflog = packed_delete_reflog,
> - .reflog_expire = packed_reflog_expire
> + .for_each_reflog_ent = NULL,
> + .for_each_reflog_ent_reverse = NULL,
> + .reflog_exists = NULL,
> + .create_reflog = NULL,
> + .delete_reflog = NULL,
> + .reflog_expire = NULL,
Yup, the entry in vtable being set to NULL is a more direct sign the
readers would appreciate than a name natural for the method, whose
definition needs to be consulted before the readers can realize that
it is a "missing" method.
Very sensible.
Thanks.
next prev parent reply other threads:[~2022-03-17 17:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 17:27 [PATCH 0/5] refs: designated init & missing debug in ps/fetch-mirror-optim Ævar Arnfjörð Bjarmason
2022-03-17 17:27 ` [PATCH 1/5] refs: use designated initializers for "struct ref_storage_be" Ævar Arnfjörð Bjarmason
2022-03-17 17:27 ` [PATCH 2/5] refs: use designated initializers for "struct ref_iterator_vtable" Ævar Arnfjörð Bjarmason
2022-03-17 17:27 ` [PATCH 3/5] misc *.c: use designated initializers for struct assignments Ævar Arnfjörð Bjarmason
2022-03-17 17:27 ` [PATCH 4/5] packed-backend: remove stub BUG(...) functions Ævar Arnfjörð Bjarmason
2022-03-17 17:39 ` Junio C Hamano [this message]
2022-03-17 17:27 ` [PATCH 5/5] refs debug: add a wrapper for "read_symbolic_ref" Ævar Arnfjörð Bjarmason
2022-03-17 17:45 ` [PATCH 0/5] refs: designated init & missing debug in ps/fetch-mirror-optim Han-Wen Nienhuys
2022-03-18 12:40 ` Ævar Arnfjörð Bjarmason
2022-03-21 11:10 ` Patrick Steinhardt
2022-03-21 19:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlex8h40g.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=hanwen@google.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.