From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Martin Ågren" <martin.agren@gmail.com>,
git@vger.kernel.org, "Taylor Blau" <me@ttaylorr.com>
Subject: Re: [PATCH v2] load_ref_decorations(): fix decoration with tags
Date: Tue, 13 Jul 2021 14:40:08 -0700 [thread overview]
Message-ID: <xmqqlf6928qv.fsf@gitster.g> (raw)
In-Reply-To: <YO4FObgRvpt1nVr0@coredump.intra.peff.net> (Jeff King's message of "Tue, 13 Jul 2021 17:27:21 -0400")
Jeff King <peff@peff.net> writes:
>> Puzzled.
>
> ...and the answer is that we don't need to parse it. The tag object
> mentions the type of what it points to, and we use lookup_commit(), etc,
> to create the object pointed to by its "tagged" field.
Ahh, parse_object() on the outer tag, when instantiating the in-core
obj, allocated an in-core object and that instance is already given
a type from the tag object and .taggeed member points at that
object, so it is not an "unknown" object (tag.c::parse_tag_buffer()).
Totally forgot about that one; thanks.
next prev parent reply other threads:[~2021-07-13 21:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 22:41 [PATCH v1] load_ref_decorations(): fix decoration with tags Martin Ågren
2021-07-13 0:06 ` Jeff King
2021-07-13 7:40 ` [PATCH v2] " Martin Ågren
2021-07-13 7:52 ` Jeff King
2021-07-13 8:47 ` Martin Ågren
2021-07-13 21:17 ` Junio C Hamano
2021-07-13 21:27 ` Jeff King
2021-07-13 21:40 ` Junio C Hamano [this message]
2021-07-13 21:52 ` Martin Ågren
2021-07-13 22:22 ` Jeff King
2021-07-14 8:13 ` Martin Ågren
2021-07-14 16:31 ` [PATCH v3] " Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlf6928qv.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.