All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Michael Haggerty <mhagger@alum.mit.edu>
Subject: Re: [PATCH] pretty: lazy-load commit data when expanding user-format
Date: Thu, 28 Jan 2021 15:25:47 -0800	[thread overview]
Message-ID: <xmqqlfccve2s.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <YBMXM83xCZvC5WyA@coredump.intra.peff.net> (Jeff King's message of "Thu, 28 Jan 2021 14:57:39 -0500")

Jeff King <peff@peff.net> writes:

> I added the final test to show where we don't improve (the 1% there is
> just lucky noise), but also as a regression test to make sure we're not
> doing anything stupid like loading the commit multiple times when there
> are several placeholders that need it.
>
> Reported-by: Michael Haggerty <mhagger@alum.mit.edu>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> This benefits "rev-list --format=", as well, though there you can also
> use things like "--parents" instead, which are already fast.

Quite pleased to see more work lazily done (and personally I am
happy to see Michael's name on the list---say Hi, I missed him).


      parent reply	other threads:[~2021-01-28 23:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-28 19:57 [PATCH] pretty: lazy-load commit data when expanding user-format Jeff King
2021-01-28 22:36 ` Ævar Arnfjörð Bjarmason
2021-01-29  1:11   ` Jeff King
2021-01-28 22:58 ` Taylor Blau
2021-01-28 23:25 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqlfccve2s.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=mhagger@alum.mit.edu \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.