All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Jakub Zaverka <jakub.zaverka@deutsche-boerse.com>,
	"git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: difftool uses hardcoded perl shebang
Date: Tue, 19 Dec 2017 08:33:22 -0800	[thread overview]
Message-ID: <xmqqlghywuct.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171219162528.GA5804@sigill.intra.peff.net> (Jeff King's message of "Tue, 19 Dec 2017 11:25:28 -0500")

Jeff King <peff@peff.net> writes:

> This is a build-time knob. When you build git, try:
>
>   make PERL_PATH='/usr/bin/env perl'
>
> (If you don't build your own git, then you might raise the issue with
> whomever packages your binary).

I somehow thought ANYTHING_PATH was meant to point at the exact path
(as opposed to ANYTHING_COMMAND which is a command line), so it is
within our rights to do

    test -x "$GIT_EXEC_PATH" || die "Your Git installation is broken"

but your suggestion above makes such a sanity check impossible.

I'd understand if it were

	make PERL_PATH=$(type --path perl)

of course, though.

> As an aside, git-difftool is now a C builtin these days, so the problem
> might also go away if you upgrade. ;)

Yup, true, true.

  reply	other threads:[~2017-12-19 16:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-19 13:28 difftool uses hardcoded perl shebang Jakub Zaverka
2017-12-19 16:12 ` Junio C Hamano
2017-12-19 16:16   ` Jakub Zaverka
2017-12-19 16:25 ` Jeff King
2017-12-19 16:33   ` Junio C Hamano [this message]
2017-12-19 16:45     ` Jeff King
2017-12-19 17:08       ` Junio C Hamano
2017-12-19 17:12         ` Jeff King
2017-12-19 17:47           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqlghywuct.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jakub.zaverka@deutsche-boerse.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.