From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Stefan Beller <sbeller@google.com>,
Eric Sunshine <sunshine@sunshineco.com>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH 1/5] p5550: factor our nonsense-pack creation
Date: Thu, 23 Nov 2017 11:41:25 +0900 [thread overview]
Message-ID: <xmqqlgixra22.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171122223817.GB1405@sigill> (Jeff King's message of "Wed, 22 Nov 2017 17:38:17 -0500")
Jeff King <peff@peff.net> writes:
> Right, I came to the same conclusion (we may even have discussed this on
> the list, I don't remember). The current "todo" format says that only
> the command and sha1 matter, and we'd be changing that. Maybe that's not
> so bad if the user has to enable the feature themselves (and clearly it
> would be incompatible with a custom format option).
If you are in the habit of always writing 4 or more lines, the
chance that you would make a typo on the line you can correct in the
"todo" list with such a feature is at most 25% ;-).
I think one downside is that a mere presence of such an option hints
that we somehow encourage people to commit with a title-only message.
next prev parent reply other threads:[~2017-11-23 2:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 20:26 [PATCH 0/5] avoiding pointless pack-directory re-scans Jeff King
2017-11-20 20:26 ` [PATCH 1/5] p5550: factor our nonsense-pack creation Jeff King
2017-11-20 23:55 ` Eric Sunshine
2017-11-21 15:58 ` Jeff King
2017-11-22 0:32 ` Stefan Beller
2017-11-22 22:38 ` Jeff King
2017-11-23 2:41 ` Junio C Hamano [this message]
2017-11-23 5:02 ` Jeff King
2017-11-20 20:27 ` [PATCH 2/5] t/perf/lib-pack: use fast-import checkpoint to create packs Jeff King
2017-11-20 20:28 ` [PATCH 3/5] p5551: add a script to test fetch pack-dir rescans Jeff King
2017-11-20 20:29 ` [PATCH 4/5] everything_local: use "quick" object existence check Jeff King
2017-11-20 20:35 ` [PATCH 5/5] sha1_file: don't re-scan pack directory for null sha1 Jeff King
2017-11-20 20:47 ` Stefan Beller
2017-11-20 20:58 ` Jeff King
2017-11-21 2:37 ` Junio C Hamano
2017-11-21 22:57 ` Jeff King
2017-11-22 1:42 ` Junio C Hamano
2017-11-22 22:36 ` Jeff King
2017-11-23 2:35 ` Junio C Hamano
2017-11-24 17:32 ` Jeff King
2017-11-25 3:20 ` Junio C Hamano
2017-11-21 5:20 ` Junio C Hamano
2017-11-21 23:17 ` Jeff King
2017-11-22 1:49 ` Junio C Hamano
2017-11-22 3:17 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlgixra22.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sbeller@google.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.