From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
git@vger.kernel.org, Anders Kaseorg <andersk@mit.edu>
Subject: Re: [PATCH 1/3] Documentation: allow overriding timestamps of generated asciidoc
Date: Wed, 22 Nov 2017 11:50:19 +0900 [thread overview]
Message-ID: <xmqqlgizvxg4.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171122011531.GQ3429@aiede.mtv.corp.google.com> (Jonathan Nieder's message of "Tue, 21 Nov 2017 17:15:31 -0800")
Jonathan Nieder <jrnieder@gmail.com> writes:
>> touch -d @SECONDS isn't POSIX compliant, and non-Linux systems don't
>> provide it. POSIX only allows certain fixed format, and I assume that
>> non-Linux parties (maybe OpenBSD) will want to have reproducible builds
>> as well.
>
> Interesting. My knee-jerk preference is still to go with this patch
> as-is for now, since the non-portability only triggers when
> SOURCE_DATE_EPOCH is set.
As long as this patch is kept Debian-only, that is a sensible stance
to take. I am not sure (note: this is different from "I do not think")
if it is also OK for the wider public, though.
I wondered if this affects the dirtyness of the build, regardless of
how file timestamps are mucked with. It turns out that we do not
use "describe --dirty" in the GIT-VERSION-GEN script, so perhaps
it would be OK.
next prev parent reply other threads:[~2017-11-22 2:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 23:29 [PATCH 0/3] Improving build reproducibility Jonathan Nieder
2017-11-21 23:34 ` [PATCH 1/3] Documentation: allow overriding timestamps of generated asciidoc Jonathan Nieder
2017-11-22 0:54 ` brian m. carlson
2017-11-22 1:15 ` Jonathan Nieder
2017-11-22 2:50 ` Junio C Hamano [this message]
2017-11-22 4:30 ` Anders Kaseorg
2017-11-22 5:07 ` Junio C Hamano
2017-11-22 5:12 ` Jonathan Nieder
2017-11-21 23:36 ` [PATCH 2/3] git-gui: sort entries in optimized tclIndex Jonathan Nieder
2017-11-21 23:38 ` [PATCH 3/3] generate-cmdlist: avoid non-deterministic output Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlgizvxg4.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=andersk@mit.edu \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.