From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "René Scharfe" <l.s.r@web.de>,
"Ramsay Jones" <ramsay@ramsayjones.plus.com>,
"GIT Mailing-list" <git@vger.kernel.org>
Subject: Re: [PATCH] builtin/add: add a missing newline to an stderr message
Date: Tue, 08 Aug 2017 22:37:48 -0700 [thread overview]
Message-ID: <xmqqlgmt8fo3.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170808223407.GB169894@aiede.mtv.corp.google.com> (Jonathan Nieder's message of "Tue, 8 Aug 2017 15:34:07 -0700")
Jonathan Nieder <jrnieder@gmail.com> writes:
> I don't believe the force_mode without an 'x' provides a clear signal
> to the end user. Perhaps you meant %cx?
Indeed you are right. I think I saw Ramsay's v2 that has the 'x',
so let's use that version.
Thanks.
next prev parent reply other threads:[~2017-08-09 5:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 21:36 [PATCH] builtin/add: add a missing newline to an stderr message Ramsay Jones
2017-08-08 21:45 ` René Scharfe
2017-08-08 22:14 ` Junio C Hamano
2017-08-08 22:34 ` Jonathan Nieder
2017-08-09 5:37 ` Junio C Hamano [this message]
2017-08-08 23:55 ` Ramsay Jones
2017-08-08 22:34 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlgmt8fo3.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=l.s.r@web.de \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.