All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Victor Leschuk <vleschuk@accesssoftek.com>
Cc: Victor Leschuk <vleschuk@gmail.com>,
	"git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH v4] Add git-grep threads param
Date: Mon, 02 Nov 2015 07:13:10 -0800	[thread overview]
Message-ID: <xmqqlhagfn95.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <6AE1604EE3EC5F4296C096518C6B77EE5D0FDABA0C@mail.accesssoftek.com> (Victor Leschuk's message of "Sun, 1 Nov 2015 20:43:39 -0800")

Victor Leschuk <vleschuk@accesssoftek.com> writes:

> do we have any objections on this patch?

The question you should be asking is "do we have any support".

It is not like the default for any series is to be included; it is
quite the opposite.  "Is this worth having in our tree?" is the
question we all ask ourselves.

Also I think you should have CC'ed those who gave review comments on
this topic in the earlier rounds, if you wanted to receive answers
to that question (whichever one it is ;-).

Having said that, I didn't immediately spot anything objectionable.

Thanks.

  reply	other threads:[~2015-11-02 15:13 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-27 21:22 [PATCH v4] Add git-grep threads param Victor Leschuk
2015-11-02  4:43 ` Victor Leschuk
2015-11-02 15:13   ` Junio C Hamano [this message]
2015-11-03  8:36     ` Victor Leschuk
2015-11-03 17:22 ` Junio C Hamano
2015-11-04  6:40   ` Jeff King
2015-11-09 11:36     ` Victor Leschuk
2015-11-09 15:55       ` Jeff King
2015-11-09 16:34         ` Victor Leschuk
2015-11-09 16:53           ` Jeff King
2015-11-09 17:28             ` Victor Leschuk
2015-11-09 17:47               ` Jeff King
2015-11-09 17:55               ` Linus Torvalds
2015-11-09 18:13                 ` Jeff King
2015-11-09 18:32                 ` Victor Leschuk
2015-11-09 19:11                   ` Linus Torvalds
2015-11-09 19:52                     ` Victor Leschuk
     [not found]                       ` <CA+55aFyhBN5fEpB-CLQFhhDyf7nijs_Y3aZCSQAcpVPmruZLFg@mail.gmail.com>
2015-11-09 21:51                         ` Victor Leschuk
2015-11-09 18:40                 ` Stefan Beller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqlhagfn95.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=vleschuk@accesssoftek.com \
    --cc=vleschuk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.