From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Sebastian Schuberth <sschuberth@gmail.com>, git@vger.kernel.org
Subject: Re: [RFC] ident: support per-path configs by matching the path against a pattern
Date: Fri, 10 Jul 2015 14:07:46 -0700 [thread overview]
Message-ID: <xmqqlhenk9gd.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150710205821.GB1181@peff.net> (Jeff King's message of "Fri, 10 Jul 2015 16:58:21 -0400")
Jeff King <peff@peff.net> writes:
> On Fri, Jul 10, 2015 at 01:23:07PM -0700, Junio C Hamano wrote:
>
>> > - if (!strcmp(var, "include.path"))
>> > - ret = handle_path_include(value, inc);
>> > + if (!parse_config_key(var, "include", &cond, &cond_len, &key) &&
>> > + include_condition_is_true(cond, cond_len)) {
>>
>> I really like these two lines.
>>
>> Whoever designed that parse_config_key() interface either is a
>> genious or had a foresight with a crystal ball, or perhaps both.
>
> Heh. I peeked at the archive, and I think it was actually designed by
> committee. Perhaps we are greater than the sum of our parts? ;)
It does not look like a camel, though ;-).
Thanks. Let's see if Sebastian finds the direction satisfactory.
prev parent reply other threads:[~2015-07-10 21:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 9:36 [RFC] ident: support per-path configs by matching the path against a pattern Sebastian Schuberth
2015-07-10 15:10 ` Junio C Hamano
2015-07-10 15:43 ` Jeff King
2015-07-10 16:46 ` Jeff King
2015-07-10 20:23 ` Junio C Hamano
2015-07-10 20:58 ` Jeff King
2015-07-10 21:07 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlhenk9gd.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sschuberth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.