From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Stefan Beller <sbeller@google.com>,
"git\@vger.kernel.org" <git@vger.kernel.org>,
Michael Haggerty <mhagger@alum.mit.edu>
Subject: Re: Introducing a test_create_repo_bare (was Re: [PATCHv2 6/6] t5543-atomic-push.sh: add basic tests for atomic pushes)
Date: Thu, 18 Dec 2014 09:06:28 -0800 [thread overview]
Message-ID: <xmqqlhm47uqz.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20141218002825.GQ29365@google.com> (Jonathan Nieder's message of "Wed, 17 Dec 2014 16:28:25 -0800")
Jonathan Nieder <jrnieder@gmail.com> writes:
> Junio C Hamano wrote:
>
>> The issue is if some existing tests will be helped, if we had such a
>> helper.
>
> Since both bin-wrappers/git and test-lib.sh set GIT_TEMPLATE_DIR and
> templates/blt doesn't contain any enabled hooks, I don't see how such
> a helper would be useful.
Probably bin-wrappers/git has gained it after test_setup_repo
protected itself manually, and I obviously forgot about it. I agree
with your conclusion below, if test_create_repo has become a no-op
these days. Thanks.
> If making things more consistent were worth the churn, then if
> anything it would make sense to make test_create_repo private to the
> setup code in test-lib.sh and to use plain 'git init <directory>' in
> tests.
prev parent reply other threads:[~2014-12-18 17:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 23:20 Introducing a test_create_repo_bare (was Re: [PATCHv2 6/6] t5543-atomic-push.sh: add basic tests for atomic pushes) Stefan Beller
2014-12-17 23:51 ` Junio C Hamano
2014-12-18 0:14 ` Stefan Beller
2014-12-18 0:28 ` Jonathan Nieder
2014-12-18 17:06 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlhm47uqz.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=mhagger@alum.mit.edu \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.