From: Junio C Hamano <gitster@pobox.com>
To: Heiko Voigt <hvoigt@hvoigt.net>
Cc: Charlie Dyson <charlie@charliedyson.net>,
git@vger.kernel.org, Jens Lehmann <jens.lehmann@web.de>
Subject: Re: git-submodule.sh respects submodule.$name.update in .git/config but not .gitmodules
Date: Mon, 09 Dec 2013 15:40:47 -0800 [thread overview]
Message-ID: <xmqqlhztvbi8.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20131209223506.GF9606@sandbox-ub> (Heiko Voigt's message of "Mon, 9 Dec 2013 23:35:06 +0100")
Heiko Voigt <hvoigt@hvoigt.net> writes:
> This notion has changed in a way that only the url (by that the name)
> should be copied on init. The default for everything else should come
> from .gitmodules or gits own default.
I think you need to be a bit careful here. I do not think
everything should blindly default to .gitmodules (otherwise there
are obvious security implications as well as usability ones).
> The update configuration option was implemented before we realized that.
> So currently it is still copied when submodule init is called. The main
> reason is that we have not found the time to change that.
And 'update', as it allows any custom way to run it, is unlikely to
be allowed to be used blindly from .gitmodules, no?
next prev parent reply other threads:[~2013-12-09 23:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 15:48 git-submodule.sh respects submodule.$name.update in .git/config but not .gitmodules Charlie Dyson
2013-12-09 22:35 ` Heiko Voigt
2013-12-09 23:40 ` Junio C Hamano [this message]
2013-12-11 22:26 ` Jens Lehmann
2013-12-11 22:44 ` W. Trevor King
2013-12-12 1:16 ` Junio C Hamano
2013-12-12 18:57 ` Jens Lehmann
2013-12-12 19:14 ` W. Trevor King
2013-12-12 19:23 ` Jonathan Nieder
2013-12-12 21:17 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlhztvbi8.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=charlie@charliedyson.net \
--cc=git@vger.kernel.org \
--cc=hvoigt@hvoigt.net \
--cc=jens.lehmann@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.