From: Junio C Hamano <gitster@pobox.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH 1/3] for-each-ref: introduce %C(...) for color
Date: Fri, 01 Nov 2013 08:05:33 -0700 [thread overview]
Message-ID: <xmqqli182mde.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CALkWK0nEMpVUkzafjDkVV-uaLTYzHYUTsZkmwRPkLFa=8NEkPA@mail.gmail.com> (Ramkumar Ramachandra's message of "Fri, 1 Nov 2013 14:07:56 +0530")
Ramkumar Ramachandra <artagnon@gmail.com> writes:
> Junio C Hamano wrote:
>> Ramkumar Ramachandra <artagnon@gmail.com> writes:
>>
>>> Enhance 'git for-each-ref' with color formatting options. You can now
>>> use the following format in for-each-ref:
>>>
>>> %C(green)%(refname:short)%C(reset)
>>
>> So far, every magic for-each-ref takes were of form %(...); was
>> there a reason why this had to be %C(...), not %(color=blah), or
>> something more in-line with the existing other magic?
>
> It is in-line with the color specification in pretty-formats. Would
> you strongly prefer something else?
This patch is about for-each-ref and your series does not seem to
aim to unify it in any way with pretty-formats, so I would have
expected an enhancement in line with the former, not the latter.
next prev parent reply other threads:[~2013-11-01 15:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 9:46 [PATCH (resend) 0/3] Minor f-e-r enhacements Ramkumar Ramachandra
2013-10-31 9:46 ` [PATCH 1/3] for-each-ref: introduce %C(...) for color Ramkumar Ramachandra
2013-10-31 20:50 ` Junio C Hamano
2013-11-01 8:37 ` Ramkumar Ramachandra
2013-11-01 15:05 ` Junio C Hamano [this message]
2013-11-02 6:02 ` Ramkumar Ramachandra
2013-11-04 18:17 ` Junio C Hamano
2013-11-07 6:36 ` Ramkumar Ramachandra
2013-11-07 18:02 ` Junio C Hamano
2013-11-08 12:14 ` Ramkumar Ramachandra
2013-11-08 17:30 ` Junio C Hamano
2013-11-12 3:38 ` Ramkumar Ramachandra
2013-10-31 9:46 ` [PATCH 2/3] for-each-ref: introduce %(HEAD) asterisk marker Ramkumar Ramachandra
2013-10-31 9:46 ` [PATCH 3/3] for-each-ref: introduce %(upstream:track[short]) Ramkumar Ramachandra
2013-11-01 17:17 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2013-09-27 12:10 [PATCH 0/3] Juggling between hot branches Ramkumar Ramachandra
2013-09-27 12:10 ` [PATCH 1/3] for-each-ref: introduce %C(...) for color Ramkumar Ramachandra
2013-09-27 13:16 ` Phil Hord
2013-05-24 14:19 [PATCH v2 0/3] Towards a useable git-branch Ramkumar Ramachandra
2013-05-24 14:19 ` [PATCH 1/3] for-each-ref: introduce %C(...) for color Ramkumar Ramachandra
2013-05-24 20:56 ` Antoine Pelisse
2013-05-25 11:50 ` Ramkumar Ramachandra
2013-05-25 12:20 ` John Keeping
2013-05-25 12:54 ` Ramkumar Ramachandra
2013-05-25 12:35 ` Antoine Pelisse
2013-05-24 23:41 ` David Aguilar
2013-05-25 11:51 ` Ramkumar Ramachandra
2013-05-25 6:29 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqli182mde.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.