From: Junio C Hamano <gitster@pobox.com>
To: "Roger Koranteng via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Elijah Newren <newren@gmail.com>,
Patrick Steinhardt <ps@pks.im>,
Kaartic Sivaraam <kaartic.sivaraam@gmail.com>,
Christian Couder <christian.couder@gmail.com>,
Siddharth Asthana <siddharthasthana31@gmail.com>,
Usman Akinyemi <usmanakinyemi202@gmail.com>,
Laveesh Bansal <laveeshb@laveeshbansal.com>,
Roger Koranteng <rogerkorantenng@gmail.com>
Subject: Re: [PATCH v2] t1010: add basic tests for mktree --batch
Date: Wed, 11 Nov 2026 13:50:11 -0800 [thread overview]
Message-ID: <xmqqmrrfm418.fsf@gitster.g> (raw)
In-Reply-To: <pull.2270.v2.git.1794348807240.gitgitgadget@gmail.com> (Roger Koranteng via GitGitGadget's message of "Tue, 10 Nov 2026 22:13:27 +0000")
"Roger Koranteng via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Roger Koranteng <rogerkorantenng@gmail.com>
>
> The only "mktree --batch" test in t1010 is the one checking that it
> survives a concurrent repack. Nothing covers basic batch mode, which
> is how the leak fixed in 6272f3bd17 (mktree: plug per-tree leak in
> --batch mode, 2026-08-29) went unnoticed.
>
> Add a few tests for it. Two trees in one batch should get the same
> IDs as running plain "mktree" on each, a trailing blank line should
> not add an extra tree, -z input should work, and a tree that names a
> missing object should make mktree die after printing the trees before
> it. While at it, check that a blank line is rejected without --batch.
>
> Suggested-by: Jeff King <peff@peff.net>
> Tested-by: Laveesh Bansal <laveeshb@laveeshbansal.com>
> Signed-off-by: Roger Koranteng <rogerkorantenng@gmail.com>
> ---
Thanks, for writing and testing. Queued.
prev parent reply other threads:[~2026-11-11 21:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 11:54 [PATCH] t1010: add basic tests for mktree --batch Roger Koranteng via GitGitGadget
2026-11-09 23:12 ` Laveesh Bansal
2026-11-10 22:13 ` [PATCH v2] " Roger Koranteng via GitGitGadget
2026-11-11 21:50 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmrrfm418.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=kaartic.sivaraam@gmail.com \
--cc=laveeshb@laveeshbansal.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
--cc=rogerkorantenng@gmail.com \
--cc=siddharthasthana31@gmail.com \
--cc=usmanakinyemi202@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.