All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Stanislav Aleksandrov <lightofmysoul@gmail.com>
Cc: git@vger.kernel.org,  Patrick Steinhardt <ps@pks.im>,
	 Adrian Ratiu <adrian.ratiu@collabora.com>,
	 Jacob Keller <jacob.keller@gmail.com>, Jeff King <peff@peff.net>
Subject: Re: [RFC PATCH] submodule: make '^/' work like '../' but with an absolute path
Date: Tue, 27 Oct 2026 10:39:29 -0700	[thread overview]
Message-ID: <xmqqmrrzkppq.fsf@gitster.g> (raw)
In-Reply-To: <20260929185122.3127574-1-lightofmysoul@gmail.com> (Stanislav Aleksandrov's message of "Tue, 29 Sep 2026 18:51:22 +0000")

Stanislav Aleksandrov <lightofmysoul@gmail.com> writes:

>  Documentation/git-submodule.adoc       |   8 +-
>  Documentation/gitmodules.adoc          |   7 +-
>  builtin/submodule--helper.c            |  39 +++--
>  remote.c                               |  61 ++++++++
>  remote.h                               |  15 ++
>  submodule-config.c                     |   8 +-
>  submodule-config.h                     |   6 +
>  t/helper/test-submodule.c              |   7 +-
>  t/meson.build                          |   1 +
>  t/t0060-path-utils.sh                  |  43 ++++++
>  t/t7427-submodule-root-relative-url.sh | 190 +++++++++++++++++++++++++
>  t/t7450-bad-git-dotfiles.sh            |   5 +
>  12 files changed, 366 insertions(+), 24 deletions(-)
>  create mode 100755 t/t7427-submodule-root-relative-url.sh

Jacob seem to have had a reasonably well informed convesation with
you on this topic, and I'd trust his judgement much better than mine
on submodules ;-), so I was looking at this patch to queue.

One bad news is that t7427 is taken by another topic in flight, and
this topic will break tests when merged to 'seen'.  I'll try moving
it to t7428 before queuing, but when a new iteration of the patch is
posted, please make sure to check (1) it applies cleanly to 'master',
(2) the result of (1) merges cleanly to 'next' and 'seen', and all
three pass all tests (not just 0060, 7428, and 7450).

Thanks.

      parent reply	other threads:[~2026-10-27 17:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29 18:51 [RFC PATCH] submodule: make '^/' work like '../' but with an absolute path Stanislav Aleksandrov
2026-10-25 19:42 ` Jacob Keller
2026-10-25 21:25   ` Stanislav Aleksandrov
2026-10-25 23:11     ` Jacob Keller
2026-10-27 17:39 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmrrzkppq.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=adrian.ratiu@collabora.com \
    --cc=git@vger.kernel.org \
    --cc=jacob.keller@gmail.com \
    --cc=lightofmysoul@gmail.com \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.