All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Sam Bostock via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,  Eric Sunshine <sunshine@sunshineco.com>,
	 Sam Bostock <sam.bostock@shopify.com>
Subject: Re: [PATCH v2 2/2] worktree: use 'prune' instead of 'expire' in help text
Date: Sat, 20 Dec 2025 15:11:09 +0900	[thread overview]
Message-ID: <xmqqms3du1he.fsf@gitster.g> (raw)
In-Reply-To: <ff4732b72a0d8c97c668167308039918362ffb9c.1766168169.git.gitgitgadget@gmail.com> (Sam Bostock via GitGitGadget's message of "Fri, 19 Dec 2025 18:16:09 +0000")

"Sam Bostock via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Sam Bostock <sam.bostock@shopify.com>
>
> Use 'prune' instead of 'expire' when describing the --expire option's
> effect on missing worktrees, since the terminology is clearer.
>
> Signed-off-by: Sam Bostock <sam@sambostock.ca>
> ---
>  Documentation/git-worktree.adoc | 2 +-
>  builtin/worktree.c              | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Does this v2 use exactly the same commit from v1 as [1/2] and add
this [2/2] as if you are saying "oops, the previous one missed
something we should have updated but forgot/failed to do so; here is
an improvement?"

Don't.  Unless the change you deliberately made as a follow-up
improvement is logically separate and significant, that is.

Thanks.

  reply	other threads:[~2025-12-20  6:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-19 15:00 [PATCH] worktree: clarify --expire applies to missing worktrees Sam Bostock via GitGitGadget
2025-12-19 15:11 ` Eric Sunshine
2025-12-20  5:44   ` Junio C Hamano
2025-12-20  7:14     ` Eric Sunshine
2025-12-20  7:31       ` Junio C Hamano
2025-12-20  8:23         ` Eric Sunshine
2025-12-19 18:16 ` [PATCH v2 0/2] " Sam Bostock via GitGitGadget
2025-12-19 18:16   ` [PATCH v2 1/2] " Sam Bostock via GitGitGadget
2025-12-20  6:07     ` Junio C Hamano
2025-12-19 18:16   ` [PATCH v2 2/2] worktree: use 'prune' instead of 'expire' in help text Sam Bostock via GitGitGadget
2025-12-20  6:11     ` Junio C Hamano [this message]
2026-01-21 19:55   ` [PATCH v2 0/2] worktree: clarify --expire applies to missing worktrees Junio C Hamano
2026-01-28  5:39   ` [PATCH v3] worktree: clarify that --expire only affects " Sam Bostock via GitGitGadget
2026-01-30  0:29     ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqms3du1he.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=sam.bostock@shopify.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.