All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Knut Harald Ryager via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,  Knut Harald Ryager <e-k-nut@hotmail.com>
Subject: Re: [PATCH v3] docs: remove stray bracket from git-clone synopsis
Date: Tue, 12 Aug 2025 08:55:29 -0700	[thread overview]
Message-ID: <xmqqms84v8jy.fsf@gitster.g> (raw)
In-Reply-To: <pull.2023.v3.git.git.1754949872593.gitgitgadget@gmail.com> (Knut Harald Ryager via GitGitGadget's message of "Mon, 11 Aug 2025 22:04:32 +0000")

"Knut Harald Ryager via GitGitGadget" <gitgitgadget@gmail.com>
writes:

> From: Knut Harald Ryager <e-k-nut@hotmail.com>
>
> Remove the extra and incorrect closing bracket, so that the line reads:
>
>     [--filter=<filter> [--also-filter-submodules]]
>
> instead of
>
>     [--filter=<filter>] [--also-filter-submodules]]
>
> Note: Both filter options were grouped when --also-filter-submodules
> was added by commit f05da2b4. The extra bracket was added
> later by commit 76880f05.
>
> Signed-off-by: Knut Harald Ryager <e-k-nut@hotmail.com>
> ---

Thanks.  Let me rewrite the proposed log message thusly:

--- >8 ---
Subject: docs: remove stray bracket from git-clone synopsis

The synopsis section has an extra closing bracket, like this:

    [--filter=<filter>] [--also-filter-submodules]]

The extra one is not the one at the end of this line; it is the one
after "...=<filter>".

The "--also-filter-submodules" option was added by f05da2b4 (clone,
submodule: pass partial clone filters to submodules, 2022-02-04).
Because it makes sense only when used with the "--filter=<filter>"
option, these two options are enclosed in a pair of brackets.  The
extra one was added by 76880f05 (doc: git-clone: apply new
documentation formatting guidelines, 2024-03-29) by mistake.

Remove the extra and incorrect closing bracket, so that the line
reads:

    [--filter=<filter> [--also-filter-submodules]]

Signed-off-by: Knut Harald Ryager <e-k-nut@hotmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

      reply	other threads:[~2025-08-12 15:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-31 14:46 [PATCH] docs: remove stray bracket from git-clone synopsis Knut Harald Ryager via GitGitGadget
2025-07-31 19:07 ` Junio C Hamano
2025-08-10 21:30 ` [PATCH v2] Remove the extra and incorrect closing bracket, so that the line reads: Knut Harald Ryager via GitGitGadget
2025-08-11  6:14   ` Kristoffer Haugsbakk
2025-08-11 16:07     ` Junio C Hamano
2025-08-11 22:04   ` [PATCH v3] docs: remove stray bracket from git-clone synopsis Knut Harald Ryager via GitGitGadget
2025-08-12 15:55     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqms84v8jy.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=e-k-nut@hotmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.