All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Josh Heinrichs <joshiheinrichs@gmail.com>,  git@vger.kernel.org
Subject: Re: [PATCH 1/1] maintenance: fix launchctl calendar intervals
Date: Wed, 23 Apr 2025 13:31:39 -0700	[thread overview]
Message-ID: <xmqqmsc6wrf8.fsf@gitster.g> (raw)
In-Reply-To: <d5cdcfe0-5dd1-46ed-9860-a9949bd6b3b5@gmail.com> (Derrick Stolee's message of "Wed, 23 Apr 2025 15:25:11 -0400")

Derrick Stolee <stolee@gmail.com> writes:

> On 4/21/2025 1:42 PM, Junio C Hamano wrote:
>> Josh Heinrichs <joshiheinrichs@gmail.com> writes:
>> 
>>> When using the launchctl scheduler, the weekly job runs daily, and the
>>> daily job runs on the first six days of each month. This appears to be
>>> due to specifying "Day" in the calendar intervals, which according to
>>> launchd.plist(5) is for specifying days of the month rather than days of
>>> the week. The behaviour of running a job on the 0th day is undocumented,
>>> but in my testing appears to be the same as not specifying "Day" in the
>>> calendar interval, in which case the job will run daily.
>>>
>>> Use "Weekday" in the calendar intervals, which is the correct way to
>>> schedule jobs to run on specific days of the week.
>
> Wow, good find! Thank you for submitting a fix for this issue.

Yes, good find indeed.  Tweaked in your Acked-by and will merge to
'next'.

Thanks, all.

      reply	other threads:[~2025-04-23 20:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-21  5:46 [PATCH 0/1] maintenance: fix launchctl calendar intervals Josh Heinrichs
2025-04-21  5:46 ` [PATCH 1/1] " Josh Heinrichs
2025-04-21 17:42   ` Junio C Hamano
2025-04-23 19:25     ` Derrick Stolee
2025-04-23 20:31       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmsc6wrf8.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=joshiheinrichs@gmail.com \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.