All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Simon Marchi" <simon.marchi@efficios.com>,
	git@vger.kernel.org, "René Scharfe" <l.s.r@web.de>,
	"Taylor Blau" <me@ttaylorr.com>, "Patrick Steinhardt" <ps@pks.im>
Subject: Re: [PATCH] builtin/difftool: intialize some hashmap variables
Date: Tue, 12 Nov 2024 08:51:40 +0900	[thread overview]
Message-ID: <xmqqmsi59vn7.fsf@gitster.g> (raw)
In-Reply-To: <20241111220959.GE5019@coredump.intra.peff.net> (Jeff King's message of "Mon, 11 Nov 2024 17:09:59 -0500")

Jeff King <peff@peff.net> writes:

>> Please let me know if you want a v2 or if you are just going to merge an
>> updated version of this patch.
>
> That's up to the maintainer. IMHO it's worth using HASHMAP_INIT, though,
> and perhaps adding a test.

Yup, please do.

Thanks.

      reply	other threads:[~2024-11-11 23:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-11 16:21 [PATCH] builtin/difftool: intialize some hashmap variables Simon Marchi
2024-11-11 20:54 ` Jeff King
2024-11-11 21:22   ` Simon Marchi
2024-11-11 22:09     ` Jeff King
2024-11-11 23:51       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmsi59vn7.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=l.s.r@web.de \
    --cc=me@ttaylorr.com \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    --cc=simon.marchi@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.