From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: "René Scharfe" <l.s.r@web.de>, "Git List" <git@vger.kernel.org>
Subject: Re: [PATCH] remote: plug memory leaks at early returns
Date: Mon, 26 Aug 2024 08:11:50 -0700 [thread overview]
Message-ID: <xmqqmskznwsp.fsf@gitster.g> (raw)
In-Reply-To: <ZswUWj_dg7-kM8b0@tanuki> (Patrick Steinhardt's message of "Mon, 26 Aug 2024 07:36:26 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> On Fri, Aug 23, 2024 at 02:13:09PM -0700, Junio C Hamano wrote:
>> René Scharfe <l.s.r@web.de> writes:
>>
>> > Signed-off-by: René Scharfe <l.s.r@web.de>
>> > ---
>> > builtin/remote.c | 23 +++++++++++++++--------
>> > 1 file changed, 15 insertions(+), 8 deletions(-)
>>
>> Looks straight-forward. Does this allow us to mark any test script
>> as leak-free? I understand that Patrick has another round of
>> leakfixes topic that is not yet published, and I'd prefer to see us
>> not step each other's toes.
>
> No, this doesn't conflict with anything I have. And even if it did, I'd
> be happy to drop some patches from my local series :)
>
> The changes themselves also look good to me, thanks!
Thanks. Will mark for "next".
prev parent reply other threads:[~2024-08-26 15:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 20:21 [PATCH] remote: plug memory leaks at early returns René Scharfe
2024-08-23 21:13 ` Junio C Hamano
2024-08-24 8:06 ` René Scharfe
2024-08-26 5:36 ` Patrick Steinhardt
2024-08-26 15:11 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmskznwsp.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.