Re: [RFC PATCH 0/6] [RFC] Introduce cgit-rs, a Rust wrapper around libgit.a

[Junio C Hamano <gitster@pobox.com>]

Josh Steadmon <steadmon@google.com> writes:

> On 2024.08.09 13:54, Junio C Hamano wrote:
>> Junio C Hamano <gitster@pobox.com> writes:
>> 
>> > Josh Steadmon <steadmon@google.com> writes:
>> >
>> >> We're sending this series as RFC because there is remaining work
>> >> we'd like to do, but we'd like to get early feedback on this approach,
>> >> and particularly to ask for advice on a few topics:
>> >
>> > I am not sure how much this is reusable, after seeing comments that
>> > "cgit-rs" may not be the best name for this thing and pathnames may
>> > have to change, but I needed the following merge-fix to get this
>> > into "seen" and have the result pass "make", due to interactions
>> > with the ps/config-wo-the-repository topic.
>> >
>> >  contrib/cgit-rs/public_symbol_export.c | 4 +++-
>> >  1 file changed, 3 insertions(+), 1 deletion(-)
>> 
>> There is another thing.
>> 
>> Listing this file in $(OBJECTS) means that you should be able to
>> pass "make sparse" to build contrib/cgit-rs/public_symbol_export.sp
>> but it seems to fail rather miserably.  I am tempted to suggest in
>> the meantime to futz with $(SP_OBJ) to filter it out in the top
>> level Makefile.
>
> I believe that I fixed `make sparse` (at least in GitHub CI, it fails
> for seemingly unrelated reasons on my desktop) by removing some
> unnecessarily exposed symbols in public_symbol_export.c. If it still
> fails for you in V2, please let me know.

Thanks.  Please let me know when you send v2 out ;-)