From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: git@vger.kernel.org, "Glen Choo" <chooglen@google.com>,
"Taylor Blau" <me@ttaylorr.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Elijah Newren" <newren@gmail.com>
Subject: Re: [PATCH] cocci: remove 'unused.cocci'
Date: Thu, 20 Apr 2023 19:43:14 -0700 [thread overview]
Message-ID: <xmqqmt32lzul.fsf@gitster.g> (raw)
In-Reply-To: 20230420205350.600760-1-szeder.dev@gmail.com
SZEDER Gábor <szeder.dev@gmail.com> writes:
> When 'unused.cocci' was added in 4f40f6cb73 (cocci: add and apply a
> rule to find "unused" strbufs, 2022-07-05) it found three unused
> strbufs, and when it was generalized in the next commit it managed to
> find an unused string_list as well. That's four unused variables in
> over 17 years, so apparently we rarely make this mistake.
>
> Unfortunately, applying 'unused.cocci' is quite expensive, e.g. it
> increases the from-scratch runtime of 'make coccicheck' by over 5:30
> minutes or over 160%:
> ...
> That's a lot of runtime spent for not much in return, and arguably an
> unused struct instance sneaking in is not that big of a deal to
> justify the significantly increased runtime.
>
> Remove 'unused.cocci', because we are not getting our CPU cycles'
> worth.
Will queue. Thanks.
next prev parent reply other threads:[~2023-04-21 2:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 20:05 [PATCH 0/2] cocci: codify authoring and reviewing practices Glen Choo via GitGitGadget
2023-04-12 20:05 ` [PATCH 1/2] cocci: add headings to and reword README Glen Choo via GitGitGadget
2023-04-12 21:18 ` Junio C Hamano
2023-04-13 18:37 ` Glen Choo
2023-04-13 18:51 ` Junio C Hamano
2023-04-12 20:05 ` [PATCH 2/2] cocci: codify authoring and reviewing practices Glen Choo via GitGitGadget
2023-04-16 7:42 ` SZEDER Gábor
2023-04-19 19:29 ` Glen Choo
2023-04-20 20:53 ` [PATCH] cocci: remove 'unused.cocci' SZEDER Gábor
2023-04-21 2:43 ` Junio C Hamano [this message]
2023-05-01 13:27 ` Ævar Arnfjörð Bjarmason
2023-05-01 15:55 ` Junio C Hamano
2023-05-01 17:28 ` Ævar Arnfjörð Bjarmason
2023-05-10 22:45 ` Junio C Hamano
2023-04-16 13:37 ` [PATCH 2/2] cocci: codify authoring and reviewing practices Ævar Arnfjörð Bjarmason
2023-04-19 22:30 ` Glen Choo
2023-04-15 1:27 ` [PATCH 0/2] " Elijah Newren
2023-04-17 16:21 ` Junio C Hamano
2023-04-27 22:22 ` [PATCH v2 " Glen Choo via GitGitGadget
2023-04-27 22:22 ` [PATCH v2 1/2] cocci: add headings to and reword README Glen Choo via GitGitGadget
2023-05-01 10:53 ` Ævar Arnfjörð Bjarmason
2023-05-01 15:06 ` Junio C Hamano
2023-05-02 19:29 ` Felipe Contreras
2023-05-02 19:30 ` Felipe Contreras
2023-05-09 17:54 ` Glen Choo
2023-04-27 22:22 ` [PATCH v2 2/2] cocci: codify authoring and reviewing practices Glen Choo via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmt32lzul.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=chooglen@google.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=newren@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.