From: Junio C Hamano <gitster@pobox.com>
To: "Glen Choo via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Taylor Blau <me@ttaylorr.com>,
Glen Choo <chooglen@google.com>
Subject: Re: [PATCH v3] clone: error specifically with --local and symlinked objects
Date: Tue, 11 Apr 2023 10:13:48 -0700 [thread overview]
Message-ID: <xmqqmt3e9wab.fsf@gitster.g> (raw)
In-Reply-To: <pull.1488.v3.git.git.1681232918484.gitgitgadget@gmail.com> (Glen Choo via GitGitGadget's message of "Tue, 11 Apr 2023 17:08:38 +0000")
"Glen Choo via GitGitGadget" <gitgitgadget@gmail.com> writes:
> A quick reroll to fix the style issue Taylor spotted in v2 (good
> catch!). I didn't spot this patch in 'next' or 'seen', so hopefully I'm
> still in time :)
What I locally have, which is an amended version of v2, and this one
differ like so:
diff --git a/builtin/clone.c b/builtin/clone.c
index ae2db8535a..b42231758c 100644
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -335,7 +335,6 @@ static void copy_or_link_directory(struct strbuf *src, struct strbuf *dest,
if (errno == ENOTDIR) {
int saved_errno = errno;
struct stat st;
-
if (!lstat(src->buf, &st) && S_ISLNK(st.st_mode))
die(_("'%s' is a symlink, refusing to clone with --local"),
src->buf);
So I'll keep my copy.
Thanks anyway.
next prev parent reply other threads:[~2023-04-11 17:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 23:48 [PATCH] clone: error specifically with --local and symlinked objects Glen Choo via GitGitGadget
2023-04-05 0:13 ` Junio C Hamano
2023-04-05 16:48 ` Glen Choo
2023-04-05 19:20 ` Junio C Hamano
2023-04-06 21:35 ` Taylor Blau
2023-04-06 21:55 ` Glen Choo
2023-04-06 21:27 ` Taylor Blau
2023-04-10 22:18 ` [PATCH v2] " Glen Choo via GitGitGadget
2023-04-10 22:27 ` Junio C Hamano
2023-04-10 23:16 ` Taylor Blau
2023-04-11 1:58 ` Taylor Blau
2023-04-11 17:08 ` [PATCH v3] " Glen Choo via GitGitGadget
2023-04-11 17:13 ` Junio C Hamano [this message]
2023-04-11 18:38 ` Glen Choo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmt3e9wab.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=chooglen@google.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.