From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 04/16] t5551: drop redundant grep for Accept-Language
Date: Thu, 23 Feb 2023 15:36:53 -0800 [thread overview]
Message-ID: <xmqqmt543qei.fsf@gitster.g> (raw)
In-Reply-To: Y/dFWqzaCeCbmGUs@coredump.intra.peff.net
Jeff King <peff@peff.net> writes:
> Commit b0c4adcdd7 (remote-curl: send Accept-Language header to server,
> 2022-07-11) added tests to make sure the header is sent via HTTP.
> However, it checks in two places:
>
> 1. In the expected trace output, we check verbatim for the header and
> its value.
>
> 2. Afterwards, we grep for the header again in the trace file.
>
> This (2) is probably cargo-culted from the earlier grep for
> Accept-Encoding. It is needed for the encoding because we smudge the
> value of that header when doing the verbatim check; see 1a53e692af
> (remote-curl: accept all encodings supported by curl, 2018-05-22).
>
> But we don't do so for the language header, so any problem that the
> "grep" would catch in (2) would already have been caught by (1).
Makes sense.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> t/t5551-http-fetch-smart.sh | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/t/t5551-http-fetch-smart.sh b/t/t5551-http-fetch-smart.sh
> index 10b7e7cda2..29d489768e 100755
> --- a/t/t5551-http-fetch-smart.sh
> +++ b/t/t5551-http-fetch-smart.sh
> @@ -103,10 +103,7 @@ test_expect_success 'clone http repository' '
> test_cmp exp actual.smudged &&
>
> grep "Accept-Encoding:.*gzip" actual >actual.gzip &&
> - test_line_count = 2 actual.gzip &&
> -
> - grep "Accept-Language: ko-KR, *" actual >actual.language &&
> - test_line_count = 2 actual.language
> + test_line_count = 2 actual.gzip
> fi
> '
next prev parent reply other threads:[~2023-02-23 23:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 10:48 [PATCH 0/16] http test bug potpourri Jeff King
2023-02-23 10:49 ` [PATCH 01/16] t5541: run "used receive-pack service" test earlier Jeff King
2023-02-23 10:50 ` [PATCH 02/16] t5541: stop marking "used receive-pack service" test as v0 only Jeff King
2023-02-23 10:51 ` [PATCH 03/16] t5541: simplify and move "no empty path components" test Jeff King
2023-02-23 23:36 ` Junio C Hamano
2023-02-24 2:11 ` Jeff King
2023-02-23 10:52 ` [PATCH 04/16] t5551: drop redundant grep for Accept-Language Jeff King
2023-02-23 23:36 ` Junio C Hamano [this message]
2023-02-23 10:54 ` [PATCH 05/16] t5551: lower-case headers in expected curl trace Jeff King
2023-02-23 10:56 ` [PATCH 06/16] t5551: handle HTTP/2 when checking " Jeff King
2023-02-23 10:57 ` [PATCH 07/16] t5551: stop forcing clone to run with v0 protocol Jeff King
2023-02-23 10:59 ` [PATCH 08/16] t5551: handle v2 protocol when checking curl trace Jeff King
2023-02-23 11:00 ` [PATCH 09/16] t5551: handle v2 protocol in upload-pack service test Jeff King
2023-02-23 11:01 ` [PATCH 10/16] t5551: simplify expected cookie file Jeff King
2023-02-23 11:02 ` [PATCH 11/16] t5551: handle v2 protocol in cookie test Jeff King
2023-02-23 11:05 ` [PATCH 12/16] t5551: drop curl trace lines without headers Jeff King
2023-02-23 11:05 ` [PATCH 13/16] t/lib-httpd: respect $HTTPD_PROTO in expect_askpass() Jeff King
2023-02-23 11:06 ` [PATCH 14/16] t/lib-httpd: enable HTTP/2 "h2" protocol, not just h2c Jeff King
2023-02-23 23:37 ` Junio C Hamano
2023-02-23 11:07 ` [PATCH 15/16] t5559: fix test failures with LIB_HTTPD_SSL Jeff King
2023-02-23 11:08 ` [PATCH 16/16] t5559: make SSL/TLS the default Jeff King
2023-02-23 23:37 ` [PATCH 0/16] http test bug potpourri Junio C Hamano
2023-02-24 2:13 ` Jeff King
2023-02-24 3:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmt543qei.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.