From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Volker Weißmann" <volker.weissmann@gmx.de>,
"Christian Couder" <christian.couder@gmail.com>,
git@vger.kernel.org
Subject: Re: git bisect outputs list of commits in the wrong order
Date: Fri, 10 Jun 2022 11:33:04 -0700 [thread overview]
Message-ID: <xmqqmteke5cv.fsf@gitster.g> (raw)
In-Reply-To: <YqOJQKSH4eTo4cGn@coredump.intra.peff.net> (Jeff King's message of "Fri, 10 Jun 2022 14:11:12 -0400")
Jeff King <peff@peff.net> writes:
> On Fri, Jun 10, 2022 at 10:28:04AM -0700, Junio C Hamano wrote:
>
>> I looked at an "scripted" version in the ancient past and it seems
>> to have computed by iterating over
>>
>> git rev-list bisect/bad --not $good_revs
>>
>> which would have given these intermediate ones roughly in the
>> reverse chronological order. It could be that the behaviour
>> regressed when the scripted version was rewritten in C, but I dunno.
>>
>> Christian (as an "area" expert for bisect), do you have any
>> comments?
>
> It would probably be nice to show them as --oneline, as well. I'd guess
> that a human reading the subjects of a handful of commits could quickly
> make a good guess as to the actual culprit.
True, too.
The scripted version fed the output from above iteration each to
"show-branch" (as "git log --oneline" was probably not so widely
used or may not have been available back then), to make them human
readable. We should be able to use pretty.c::pretty_print_commit()
with CMT_FMT_ONELINE to do that more easily these days.
By the way, welcome back ;-)
prev parent reply other threads:[~2022-06-10 18:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 16:01 git bisect outputs list of commits in the wrong order Volker Weißmann
2022-06-10 17:28 ` Junio C Hamano
2022-06-10 18:11 ` Jeff King
2022-06-10 18:33 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmteke5cv.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=volker.weissmann@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.