All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: js/scalar-diagnose, was Re: What's cooking in git.git (May 2022, #04; Thu, 12)
Date: Fri, 13 May 2022 08:34:59 -0700	[thread overview]
Message-ID: <xmqqmtflbg4c.fsf@gitster.g> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2205131404280.352@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Fri, 13 May 2022 14:06:56 +0200 (CEST)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> My first reaction was: but wait, what about the file mode? Then I
> remembered that René offered the opinion that we could easily introduce
> `--add-executable-file-with-contents` _iff_ we need that at some stage,
> and when I considered symbolic links, I noticed that the `--add-file`
> option does not accept those in the first place, so it would be funny if
> `--add-file-with-contents` supported symbolic links.

Knowing how we present symbolic links in the patch output, I would
actually think it is quite natural to say

    --add-virtual-file=RelNotes:120000:Documentation/RelNotes/2.37.0.txt

and be able to create a symlink.  But if we are to go in the route
to later add "--add-executable-file-with-contents", it is plausibly
a workable solution to add "--add-virtual-symbolic-link", too.  And
when it happens, we may say "why didn't we use the word 'virtual' in
the existing option names?"

By the way, should it be "--add-file-with-contents", just like you
wrote above?  The version in 'seen' says "--add-file-with-content".

Thanks.

  reply	other threads:[~2022-05-13 15:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-13  0:16 What's cooking in git.git (May 2022, #04; Thu, 12) Junio C Hamano
2022-05-13 12:06 ` js/scalar-diagnose, was " Johannes Schindelin
2022-05-13 15:34   ` Junio C Hamano [this message]
2022-05-13 19:43 ` Jeff Hostetler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmtflbg4c.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.