From: Junio C Hamano <gitster@pobox.com>
To: Lessley Dennington <lessleydennington@gmail.com>
Cc: Lessley Dennington via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, stolee@gmail.com, newren@gmail.com,
Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH v4 1/4] sparse index: enable only for git repos
Date: Mon, 29 Nov 2021 22:32:42 -0800 [thread overview]
Message-ID: <xmqqmtlm2lx1.fsf@gitster.g> (raw)
In-Reply-To: <6db27c92-6ea6-fa5f-8aa7-e1fef7d5ff5a@gmail.com> (Lessley Dennington's message of "Mon, 29 Nov 2021 15:38:03 -0800")
Lessley Dennington <lessleydennington@gmail.com> writes:
> This is cool! I applied it locally, and it seems to be working well. I
> will plan to replace my changes to checkout and pack-objects with this
> for v5.
I didn't write it to replace the changes you were preparing, though.
What the patch is meant to solve is that "git checkout -h" in a
repository, whose .git/config has some custom configuration
variables that affect how the short help text is shown, were
ignoring that per-repository settings by not even checking if we are
in a repository at all.
When "-h" is in effect, and if you are outside a repository, this
would cause the setup_git_directory_gently() function to be called,
and we'd reach checkout_main() without having discovered repository.
I do not think it removes the need for your "only when startup-info
says we have repository, do these" safety. At least, I didn't write
the patch to remove that need.
next prev parent reply other threads:[~2021-11-30 6:32 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 17:25 [PATCH 0/2] Sparse Index: diff and blame builtins Lessley Dennington via GitGitGadget
2021-10-14 17:25 ` [PATCH 1/2] diff: enable and test the sparse index Lessley Dennington via GitGitGadget
2021-10-15 16:46 ` Derrick Stolee
2021-10-14 17:25 ` [PATCH 2/2] blame: " Lessley Dennington via GitGitGadget
2021-11-23 7:57 ` Elijah Newren
2021-11-23 14:57 ` Lessley Dennington
2021-10-15 21:20 ` [PATCH v2 0/2] Sparse Index: diff and blame builtins Lessley Dennington via GitGitGadget
2021-10-15 21:20 ` [PATCH v2 1/2] diff: enable and test the sparse index Lessley Dennington via GitGitGadget
2021-10-25 20:47 ` Taylor Blau
2021-10-26 16:10 ` Lessley Dennington
2021-10-26 16:15 ` Taylor Blau
2021-10-15 21:20 ` [PATCH v2 2/2] blame: " Lessley Dennington via GitGitGadget
2021-10-25 20:53 ` Taylor Blau
2021-10-26 16:17 ` Lessley Dennington
2021-11-21 1:32 ` Elijah Newren
2021-11-01 21:27 ` [PATCH v3 0/2] Sparse Index: diff and blame builtins Lessley Dennington via GitGitGadget
2021-11-01 21:27 ` [PATCH v3 1/2] diff: enable and test the sparse index Lessley Dennington via GitGitGadget
2021-11-03 17:05 ` Junio C Hamano
2021-11-04 23:55 ` Lessley Dennington
2021-11-01 21:27 ` [PATCH v3 2/2] blame: " Lessley Dennington via GitGitGadget
2021-11-03 16:47 ` Junio C Hamano
2021-11-05 0:04 ` Lessley Dennington
2021-11-21 1:46 ` Elijah Newren
2021-11-22 22:42 ` [PATCH v4 0/4] Sparse Index: diff and blame builtins Lessley Dennington via GitGitGadget
2021-11-22 22:42 ` [PATCH v4 1/4] sparse index: enable only for git repos Lessley Dennington via GitGitGadget
2021-11-23 7:41 ` Elijah Newren
2021-11-23 14:52 ` Lessley Dennington
2021-11-23 23:39 ` Junio C Hamano
2021-11-24 14:41 ` Lessley Dennington
2021-11-24 18:23 ` Junio C Hamano
2021-11-29 23:38 ` Lessley Dennington
2021-11-30 6:32 ` Junio C Hamano [this message]
2021-11-30 23:25 ` Lessley Dennington
2021-11-22 22:42 ` [PATCH v4 2/4] test-read-cache: set up repo after git directory Lessley Dennington via GitGitGadget
2021-11-23 23:42 ` Junio C Hamano
2021-11-24 15:10 ` Lessley Dennington
2021-11-24 18:36 ` Junio C Hamano
2021-11-29 23:01 ` Lessley Dennington
2021-11-22 22:42 ` [PATCH v4 3/4] diff: enable and test the sparse index Lessley Dennington via GitGitGadget
2021-11-23 7:47 ` Elijah Newren
2021-11-23 14:53 ` Lessley Dennington
2021-11-23 23:48 ` Junio C Hamano
2021-11-22 22:42 ` [PATCH v4 4/4] blame: " Lessley Dennington via GitGitGadget
2021-11-23 23:53 ` Junio C Hamano
2021-11-24 14:52 ` Lessley Dennington
2021-12-03 21:15 ` [PATCH v5 0/7] Sparse Index: diff and blame builtins Lessley Dennington via GitGitGadget
2021-12-03 21:15 ` [PATCH v5 1/7] git: esnure correct git directory setup with -h Lessley Dennington via GitGitGadget
2021-12-04 18:41 ` Elijah Newren
2021-12-04 19:58 ` Junio C Hamano
2021-12-03 21:16 ` [PATCH v5 2/7] commit-graph: return if there is no git directory Lessley Dennington via GitGitGadget
2021-12-03 21:16 ` [PATCH v5 3/7] test-read-cache: set up repo after " Lessley Dennington via GitGitGadget
2021-12-03 21:16 ` [PATCH v5 4/7] repo-settings: prepare_repo_settings only in git repos Lessley Dennington via GitGitGadget
2021-12-07 4:43 ` Ævar Arnfjörð Bjarmason
2021-12-08 15:46 ` Lessley Dennington
2021-12-03 21:16 ` [PATCH v5 5/7] diff: replace --staged with --cached in t1092 tests Lessley Dennington via GitGitGadget
2021-12-03 21:16 ` [PATCH v5 6/7] diff: enable and test the sparse index Lessley Dennington via GitGitGadget
2021-12-03 21:16 ` [PATCH v5 7/7] blame: " Lessley Dennington via GitGitGadget
2021-12-04 19:43 ` [PATCH v5 0/7] Sparse Index: diff and blame builtins Elijah Newren
2021-12-06 15:55 ` [PATCH v6 " Lessley Dennington via GitGitGadget
2021-12-06 15:55 ` [PATCH v6 1/7] git: ensure correct git directory setup with -h Lessley Dennington via GitGitGadget
2021-12-06 15:55 ` [PATCH v6 2/7] commit-graph: return if there is no git directory Lessley Dennington via GitGitGadget
2021-12-06 15:55 ` [PATCH v6 3/7] test-read-cache: set up repo after " Lessley Dennington via GitGitGadget
2021-12-06 15:55 ` [PATCH v6 4/7] repo-settings: prepare_repo_settings only in git repos Lessley Dennington via GitGitGadget
2021-12-06 15:55 ` [PATCH v6 5/7] diff: replace --staged with --cached in t1092 tests Lessley Dennington via GitGitGadget
2021-12-06 15:56 ` [PATCH v6 6/7] diff: enable and test the sparse index Lessley Dennington via GitGitGadget
2021-12-06 15:56 ` [PATCH v6 7/7] blame: " Lessley Dennington via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmtlm2lx1.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=lessleydennington@gmail.com \
--cc=me@ttaylorr.com \
--cc=newren@gmail.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.