All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Alex Henrie <alexhenrie24@gmail.com>
Cc: git@vger.kernel.org, pc44800@gmail.com, chriscool@tuxfamily.org,
	stefanbeller@gmail.com, kaartic.sivaraam@gmail.com,
	Johannes.Schindelin@gmx.de, shouryashukla.oo@gmail.com
Subject: Re: [PATCH] submodule: use the imperative mood to describe the --files option
Date: Mon, 17 May 2021 15:56:02 +0900	[thread overview]
Message-ID: <xmqqmtst3l31.fsf@gitster.g> (raw)
In-Reply-To: 20210516215957.33341-1-alexhenrie24@gmail.com

Alex Henrie <alexhenrie24@gmail.com> writes:

> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
> ---
>  builtin/submodule--helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
> index d55f6262e9..ae6174ab05 100644
> --- a/builtin/submodule--helper.c
> +++ b/builtin/submodule--helper.c
> @@ -1300,7 +1300,7 @@ static int module_summary(int argc, const char **argv, const char *prefix)
>  		OPT_BOOL(0, "cached", &cached,
>  			 N_("use the commit stored in the index instead of the submodule HEAD")),
>  		OPT_BOOL(0, "files", &files,
> -			 N_("to compare the commit in the index with that in the submodule HEAD")),
> +			 N_("compare the commit in the index with that in the submodule HEAD")),
>  		OPT_BOOL(0, "for-status", &for_status,
>  			 N_("skip submodules with 'ignore_config' value set to 'all'")),
>  		OPT_INTEGER('n', "summary-limit", &summary_limit,

Unlike many other helper functions in this file, this one is likely
to survive when the remainder of "git submodule" scripted Porcelain
is rewritten in C, so it is a good idea to update it with this
patch.

Thanks, will queue.

      parent reply	other threads:[~2021-05-17  6:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-16 21:59 [PATCH] submodule: use the imperative mood to describe the --files option Alex Henrie
2021-05-17  5:58 ` Bagas Sanjaya
2021-05-17  6:56 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmtst3l31.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=alexhenrie24@gmail.com \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=kaartic.sivaraam@gmail.com \
    --cc=pc44800@gmail.com \
    --cc=shouryashukla.oo@gmail.com \
    --cc=stefanbeller@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.