All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: starlord via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, Jiang Xin <zhiyou.jx@alibaba-inc.com>,
	starlord <bojun.cbj@gmail.com>,
	Bojun Chen <bojun.cbj@alibaba-inc.com>
Subject: Re: [PATCH] githooks.txt: use correct "reference-transaction" hook name
Date: Fri, 24 Jul 2020 13:54:29 -0700	[thread overview]
Message-ID: <xmqqmu3ok516.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200724142156.GB1032@xps.pks.im> (Patrick Steinhardt's message of "Fri, 24 Jul 2020 16:21:56 +0200")

Patrick Steinhardt <ps@pks.im> writes:

> Hi Bojun,
>
> On Fri, Jul 24, 2020 at 01:57:57PM +0000, starlord via GitGitGadget wrote:
>> From: Bojun Chen <bojun.cbj@alibaba-inc.com>
>> 
>> The "reference transaction" hook was introduced in commit 6754159767
>> (refs: implement reference transaction hook, 2020-06-19). The name of
>> the hook is declared as "reference-transaction" in "refs.c" and
>> testcases, but the name declared in "githooks.txt" is different.
>> 
>> Signed-off-by: Bojun Chen <bojun.cbj@alibaba-inc.com>
>
> Indeed, thanks for catching this!
>
> Reviewed-by: Patrick Steinhardt <ps@pks.im>

Thanks.

      reply	other threads:[~2020-07-24 20:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-24 13:57 [PATCH] githooks.txt: use correct "reference-transaction" hook name starlord via GitGitGadget
2020-07-24 14:21 ` Patrick Steinhardt
2020-07-24 20:54   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmu3ok516.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=bojun.cbj@alibaba-inc.com \
    --cc=bojun.cbj@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=ps@pks.im \
    --cc=zhiyou.jx@alibaba-inc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.