All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Michael Haggerty <mhagger@alum.mit.edu>,
	Anders Kaseorg <andersk@mit.edu>,
	Stefan Beller <sbeller@google.com>,
	git@vger.kernel.org
Subject: Re: [PATCH v3 4/4] read_loose_refs(): treat NULL_SHA1 loose references as broken
Date: Wed, 03 Jun 2015 14:20:14 -0700	[thread overview]
Message-ID: <xmqqmw0gwktt.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150603201511.GA31157@peff.net> (Jeff King's message of "Wed, 3 Jun 2015 16:15:12 -0400")

Jeff King <peff@peff.net> writes:

> On Wed, Jun 03, 2015 at 11:51:43AM -0700, Junio C Hamano wrote:
>
>> Jeff King <peff@peff.net> writes:
>> 
>> > On Wed, Jun 03, 2015 at 03:51:59PM +0200, Michael Haggerty wrote:
>> >
>> >> NULL_SHA1 is used to indicate of "invalid SHA-1" throughout our code
>> >
>> > s/of/an/ ?
>> 
>> Also possibly s/invalid SHA-1/invalid ref/?
>
> I thought it was trying to express that we use the null sha1 as a
> sentinel value throughout the code, no matter if the value came from a
> ref or otherwise.

Yeah, an invalid object name, not limited to refs, is correct.

Thanks.

  reply	other threads:[~2015-06-03 21:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03 13:51 [PATCH v3 0/4] Fix how for-each-ref handles broken loose references Michael Haggerty
2015-06-03 13:51 ` [PATCH v3 1/4] t6301: new tests of for-each-ref error handling Michael Haggerty
2015-06-03 13:51 ` [PATCH v3 2/4] for-each-ref: report broken references correctly Michael Haggerty
2015-06-03 13:51 ` [PATCH v3 3/4] read_loose_refs(): simplify function logic Michael Haggerty
2015-06-03 13:51 ` [PATCH v3 4/4] read_loose_refs(): treat NULL_SHA1 loose references as broken Michael Haggerty
2015-06-03 14:08   ` Jeff King
2015-06-03 18:51     ` Junio C Hamano
2015-06-03 20:15       ` Jeff King
2015-06-03 21:20         ` Junio C Hamano [this message]
2015-06-08  9:26           ` Michael Haggerty
2015-06-08 17:37             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmw0gwktt.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=andersk@mit.edu \
    --cc=git@vger.kernel.org \
    --cc=mhagger@alum.mit.edu \
    --cc=peff@peff.net \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.